Skip to content

HIVE-29617: Error while loading column statistics of Iceberg table after upgrading Hive #6496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kasakrisz wants to merge 1 commit into
base: master
Choose a base branch
from
+67 −12
Open

HIVE-29617: Error while loading column statistics of Iceberg table after upgrading Hive #6496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 23 additions & 12 deletions ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,22 +239,33 @@
return aggregateStat.getNumRows();
}

private static void estimateStatsForMissingCols(List<String> neededColumns, List<ColStatistics> columnStats,
HiveConf conf, long nr, List<ColumnInfo> schema) {
/**
* Estimates column statistics for columns specified in {@code neededColumnNames}
* that do not already have statistics in the {@code existingColStats} list.
*
* @return A {@link List} of {@link ColStatistics} objects containing
* both the provided existing statistics and the newly estimated ones.
*/
static List<ColStatistics> estimateStatsForMissingCols(
List<String> neededColumnNames, List<ColStatistics> existingColStats, HiveConf conf, long nr,
List<ColumnInfo> schema) {

Set<String> neededCols = new HashSet<>(neededColumns);
Set<String> colsWithStats = new HashSet<>();
Set<String> neededCols = new HashSet<>(neededColumnNames);
Set<String> columnNamesWithStats = new HashSet<>(existingColStats.size());

Check warning on line 254 in ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this call to the constructor with the better suited static method HashSet.newHashSet(int numMappings) 


See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZ5AbEZyuAAtqiIVTMUt&open=AZ5AbEZyuAAtqiIVTMUt&pullRequest=6496
Copy link
Copy Markdown
Contributor

@soumyakanti3578 soumyakanti3578 May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Sonar's suggestion of HashSet.newHashSet(int numMappings) is more efficient. Not a blocker for this PR.


for (ColStatistics cstats : columnStats) {
colsWithStats.add(cstats.getColumnName());
for (ColStatistics cstats : existingColStats) {
columnNamesWithStats.add(cstats.getColumnName());
}

List<String> missingColStats = new ArrayList<>(Sets.difference(neededCols, colsWithStats));
List<String> missingColumnNames = new ArrayList<>(Sets.difference(neededCols, columnNamesWithStats));
ArrayList<ColStatistics> combined = new ArrayList<>(existingColStats.size() + missingColumnNames.size());
combined.addAll(existingColStats);

if (!missingColStats.isEmpty()) {
columnStats.addAll(
estimateStats(schema, missingColStats, conf, nr));
if (!missingColumnNames.isEmpty()) {
combined.addAll(estimateStats(schema, missingColumnNames, conf, nr));
}

return combined;
}

public static Statistics collectStatistics(HiveConf conf, PrunedPartitionList partList,
Expand Down Expand Up @@ -300,7 +311,7 @@
if (needColStats && !metaTable) {
colStats = getTableColumnStats(table, neededColumns, colStatsCache, fetchColStats);
if (estimateStats) {
estimateStatsForMissingCols(neededColumns, colStats, conf, nr, schema);
colStats = estimateStatsForMissingCols(neededColumns, colStats, conf, nr, schema);
Copy link
Copy Markdown
Contributor

@InvisibleProgrammer InvisibleProgrammer May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think List<ColStatistics> colStats = Collections.emptyList(); is still here. It can lead to future mistakes like trying to use it on the same way as before.

Copy link
Copy Markdown
Contributor Author

@kasakrisz kasakrisz May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the usage of the colStats reference you mentioned and is used in read operations. I haven't found any code that tries to modify it's content.

}
// we should have stats for all columns (estimated or actual)
if (neededColumns.size() == colStats.size()) {
Expand Down Expand Up @@ -386,7 +397,7 @@
boolean statsRetrieved = aggrStats != null &&
aggrStats.getColStats() != null && aggrStats.getColStatsSize() != 0;
if (neededColumns.isEmpty() || (!neededColsToRetrieve.isEmpty() && !statsRetrieved)) {
estimateStatsForMissingCols(neededColsToRetrieve, columnStats, conf, nr, schema);
columnStats = estimateStatsForMissingCols(neededColsToRetrieve, columnStats, conf, nr, schema);
// There are some partitions with no state (or we didn't fetch any state).
// Update the stats with empty list to reflect that in the
// state/initialize structures.
Expand Down
44 changes: 44 additions & 0 deletions ql/src/test/org/apache/hadoop/hive/ql/stats/TestStatsUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

package org.apache.hadoop.hive.ql.stats;

import static org.junit.Assert.assertFalse;

Check warning on line 21 in ql/src/test/org/apache/hadoop/hive/ql/stats/TestStatsUtils.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this unused import 'org.junit.Assert.assertFalse'. 


See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZ5AbEeDuAAtqiIVTMUu&open=AZ5AbEeDuAAtqiIVTMUu&pullRequest=6496

Check warning on line 21 in ql/src/test/org/apache/hadoop/hive/ql/stats/TestStatsUtils.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Unused import - org.junit.Assert.assertFalse. 


See more on https://sonarcloud.io/project/issues?id=apache_hive&issues=AZ5AbEeDuAAtqiIVTMUv&open=AZ5AbEeDuAAtqiIVTMUv&pullRequest=6496
Copy link
Copy Markdown
Contributor

@soumyakanti3578 soumyakanti3578 May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is unused, as highlighted by sonar too.

import static org.junit.Assert.assertTrue;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
Expand All @@ -41,10 +43,12 @@
import org.apache.hadoop.hive.metastore.api.LongColumnStatsData;
import org.apache.hadoop.hive.metastore.api.Timestamp;
import org.apache.hadoop.hive.metastore.api.TimestampColumnStatsData;
import org.apache.hadoop.hive.ql.exec.ColumnInfo;
import org.apache.hadoop.hive.ql.plan.ColStatistics;
import org.apache.hadoop.hive.ql.plan.ColStatistics.Range;
import org.apache.hadoop.hive.ql.plan.Statistics;
import org.apache.hadoop.hive.serde.serdeConstants;
import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoFactory;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
Expand Down Expand Up @@ -565,4 +569,44 @@
assertEquals(1700000000L, range.maxValue.longValue(), "maxValue mismatch for TIMESTAMP");
}

@Test
void testEstimateStatsForMissingColsHandlesEmptyList() {
HiveConf conf = new HiveConf();

ColumnInfo columnInfoA = new ColumnInfo("a", TypeInfoFactory.intTypeInfo, "t", false);

List<ColStatistics> allColumnStats = StatsUtils.estimateStatsForMissingCols(
List.of("a"), Collections.emptyList(), conf, 0, List.of(columnInfoA));
Copy link
Copy Markdown
Contributor

@soumyakanti3578 soumyakanti3578 May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can have a situation where neededColumnNames is empty and existingColStats is non-empty? If yes, we should probably add a test for that too?


assertEquals(1, allColumnStats.size());
}

@Test
void testEstimateStatsForMissingColsCombinesExistingStatsAndEstimations() {
HiveConf conf = new HiveConf();

ColumnInfo colNeededButNotExists = new ColumnInfo("neededButNotExists", TypeInfoFactory.intTypeInfo, "t", false);
ColumnInfo colNeededAndExists = new ColumnInfo("neededAndExists", TypeInfoFactory.intTypeInfo, "t", false);
ColumnInfo colNotNeededButExists = new ColumnInfo("notNeededButExists", TypeInfoFactory.intTypeInfo, "t", false);
ColumnInfo colNotNeededNotExists = new ColumnInfo("notNeededNotExists", TypeInfoFactory.intTypeInfo, "t", false);

ColStatistics colStatNeededAndExists = new ColStatistics();
colStatNeededAndExists.setColumnName(colNeededAndExists.getInternalName());
ColStatistics colStatNotNeededButExists = new ColStatistics();
colStatNotNeededButExists.setColumnName(colNotNeededButExists.getInternalName());

List<ColStatistics> allColumnStats = StatsUtils.estimateStatsForMissingCols(
List.of(colNeededAndExists.getInternalName(), colNeededButNotExists.getInternalName()),
List.of(colStatNeededAndExists, colStatNotNeededButExists),
conf,
0,
List.of(colNeededButNotExists, colNeededAndExists, colNotNeededButExists, colNotNeededNotExists));

assertEquals(3, allColumnStats.size());
assertEquals(allColumnStats.get(0), colStatNeededAndExists);
assertEquals(allColumnStats.get(1), colStatNotNeededButExists);
assertTrue(allColumnStats.get(2).isEstimated());
assertEquals(allColumnStats.get(2).getColumnName(), colNeededButNotExists.getInternalName());
Copy link
Copy Markdown
Contributor

@soumyakanti3578 soumyakanti3578 May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think except the first assertEquals all of them have the order of arguments flipped?

}

}
Loading