TestValidateAfterInactivity: Set maxConns to 1#673
Merged
Conversation
The test server only supports a single connection at a time, and the async client can apparently attempt to establish a second connection, possibly due to a benign race condition in how leased connections are returned to the pool.
ok2c
approved these changes
Jul 7, 2025
Member
|
@rschmitt For changes like that there is no need to raise a PR for fixes like that. They can be reviewed and backed out in the worst case post-commit. Things that generally require a review are non-functional style changes, code "beautification", those drag in new dependencies and so on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test server only supports a single connection at a time, and the async client can apparently attempt to establish a second connection, possibly due to a benign race condition in how leased connections are returned to the pool.