Add support for registering views#3288
Merged
Merged
Conversation
8 tasks
ndrluis
approved these changes
Apr 26, 2026
gabeiglio
reviewed
Apr 26, 2026
geruh
reviewed
Apr 27, 2026
Collaborator
|
Does the REST fixture support register_view? An integration test on this would be great. |
Member
Author
|
@rambleraptor No, the current test target 1.10.x doesn't support the endpoint. |
ebyhr
force-pushed
the
ebi/register_view
branch
2 times, most recently
from
cd7d26a to
f389b33
Compare
ebyhr
force-pushed
the
ebi/register_view
branch
from
f389b33 to
af7a73c
Compare
Member
Author
|
@geruh Could you take another look when you have time? |
Fokko
approved these changes
May 6, 2026
geruh
reviewed
May 7, 2026
| status_code=200, | ||
| request_headers=TEST_HEADERS, | ||
| ) | ||
| rest_mock.post( |
Member
There was a problem hiding this comment.
non blocking nit: we don't need this code block since we hit on self.table_exists() call.
Contributor
|
Thanks @ebyhr for working on this, and thanks for the review @ndrluis, @gabeiglio and @geruh 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Are these changes tested?
tests/catalog/test_rest.py contains new tests.
Are there any user-facing changes?
This PR adds a new
register_viewmethod tocatalog.