Skip to content

Filter transitive repositories with uninterpolated IDs #12050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnodet merged 1 commit into from
May 18, 2026
+8 −2
Merged

Filter transitive repositories with uninterpolated IDs #12050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,9 @@ public void mergeRepositories(Model model, boolean replace) {
// filter out transitive invalid repositories
// this should be safe because invalid repo coming from build POMs
// have been rejected earlier during validation
.filter(repo -> repo.getUrl() != null && !repo.getUrl().contains("${"))
.filter(repo -> repo.getUrl() != null
&& !repo.getUrl().contains("${")
&& (repo.getId() == null || !repo.getId().contains("${")))
.map(session::createRemoteRepository)
.toList();
if (replace) {
Expand Down
6 changes: 5 additions & 1 deletion impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,16 @@ public void testMergeRepositories() throws Exception {
Repository.newBuilder()
.id("third")
.url("${thirdParentRepo}")
.build(),
Repository.newBuilder()
.id("${uninterpolatedRepoId}")
.url("https://valid.url")
.build()))
.build();

state.mergeRepositories(model, false);

// after merge
// after merge: "second" filtered (uninterpolated URL), "${uninterpolatedRepoId}" filtered (uninterpolated ID)
repositories = (List<RemoteRepository>) repositoriesField.get(state);
assertEquals(3, repositories.size());
assertEquals("first", repositories.get(0).getId());
Expand Down
Loading