Fix #12052: Tokenize arithmetic operators as delimiters in ConditionParser#12053
Open
gnodet wants to merge 1 commit into
Open
Fix #12052: Tokenize arithmetic operators as delimiters in ConditionParser#12053gnodet wants to merge 1 commit into
gnodet wants to merge 1 commit into
Conversation
…arser The tokenizer did not recognize `-`, `*`, `/` as delimiter characters, so expressions like `5-3` or `6*4` (without spaces) were tokenized as single tokens and failed to parse. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-,*,/to the delimiter character list inConditionParser.tokenize()so arithmetic expressions without spaces (e.g.,5-3,6*4,9/3) are correctly tokenized${my-property}) are handled before the delimiter check, andparseUnary()already handles unary-Fixes #12052
Related: #11882, #12038
Test plan
testArithmeticWithoutSpacescovering all operators without spaces, operator precedence, and unary negationConditionParserTesttests passClaude Code on behalf of Guillaume Nodet