Fix #12045: fix mvnup plugin upgrade strategy for inherited plugins from remote parent POMs#12054
Merged
Merged
Conversation
…rom remote parent POMs * Fix #12045: warn when effective model analysis fails for inherited plugins Change the log level from debug to warning when effective model analysis fails in PluginUpgradeStrategy, so users are aware when plugins inherited from remote parent POMs cannot be detected for upgrade. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix standalone session transport for effective model resolution Register transporter factories via @provides methods so they properly feed into the DI Map<String, TransporterFactory>, fixing the standalone session's ability to resolve remote parent POMs from Maven Central. The previous approach of binding TransporterProvider directly was overridden by the @provides method in RepositorySystemSupplier which received an empty factory map, leaving no HTTP transport available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add test for inherited plugin detection from remote parent POM Verifies that the standalone session can resolve org.apache:apache:23 from Maven Central and detect maven-enforcer-plugin:1.4.1 in the parent's pluginManagement as needing a Maven 4 compatibility upgrade. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12046 to
maven-4.0.x.Summary
debugtowarningwhen effective model analysis fails inPluginUpgradeStrategy@Providesmethods so they properly feed into the DIMap<String, TransporterFactory>Closes #12045
Claude Code on behalf of Guillaume Nodet