-
Notifications
You must be signed in to change notification settings - Fork 1.6k
arch/arm/rp23xx: add text heap (up_textheap_memalign) support #19256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ricardgb
wants to merge
1
commit into
apache:master
Choose a base branch
from
ricardgb:rp23xx-textheap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+108
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| /**************************************************************************** | ||
| * arch/arm/src/rp23xx/rp23xx_textheap.c | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. The | ||
| * ASF licenses this file to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance with the | ||
| * License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations | ||
| * under the License. | ||
| * | ||
| ****************************************************************************/ | ||
|
|
||
| /**************************************************************************** | ||
| * Text-heap allocator for the RP2350. | ||
| * | ||
| * Dynamically loaded code (e.g. a "lifted arm" copied in from NFS) must be | ||
| * placed in memory that the CPU can both write and then execute. On the | ||
| * RP2350 the on-chip SRAM (0x20000000) is normal, executable memory, and | ||
| * this port runs without the MPU enabled (CONFIG_ARM_MPU=n), so RAM is not | ||
| * marked no-execute. The general-purpose kernel heap therefore already | ||
| * satisfies the requirements of a text heap, and these wrappers simply | ||
| * forward to it (the same approach used by arch/arm/src/cxd56xx). | ||
| * | ||
| * Because the instruction and data views of this memory are the same | ||
| * address, ARCH_HAVE_TEXT_HEAP_SEPARATE_DATA_ADDRESS is not selected and | ||
| * up_textheap_data_address() is not required. | ||
| ****************************************************************************/ | ||
|
|
||
| /**************************************************************************** | ||
| * Included Files | ||
| ****************************************************************************/ | ||
|
|
||
| #include <nuttx/config.h> | ||
|
|
||
| #include <sys/types.h> | ||
| #include <stdbool.h> | ||
|
|
||
| #include <nuttx/arch.h> | ||
| #include <nuttx/kmalloc.h> | ||
|
|
||
| #ifdef CONFIG_ARCH_USE_TEXT_HEAP | ||
|
|
||
| /**************************************************************************** | ||
| * Public Functions | ||
| ****************************************************************************/ | ||
|
|
||
| /**************************************************************************** | ||
| * Name: up_textheap_memalign | ||
| * | ||
| * Description: | ||
| * Allocate aligned, executable memory for dynamically loaded code. | ||
| * | ||
| ****************************************************************************/ | ||
|
|
||
| void *up_textheap_memalign(size_t align, size_t size) | ||
| { | ||
| return kmm_memalign(align, size); | ||
| } | ||
|
|
||
| /**************************************************************************** | ||
| * Name: up_textheap_free | ||
| * | ||
| * Description: | ||
| * Free memory previously returned by up_textheap_memalign(). | ||
| * | ||
| ****************************************************************************/ | ||
|
|
||
| void up_textheap_free(void *p) | ||
| { | ||
| if (p != NULL) | ||
| { | ||
| kmm_free(p); | ||
| } | ||
| } | ||
|
|
||
| /**************************************************************************** | ||
| * Name: up_textheap_heapmember | ||
| * | ||
| * Description: | ||
| * Test if the given address was allocated from the text heap. | ||
| * | ||
| ****************************************************************************/ | ||
|
|
||
| bool up_textheap_heapmember(void *p) | ||
| { | ||
| return kmm_heapmember(p); | ||
| } | ||
|
|
||
| #endif /* CONFIG_ARCH_USE_TEXT_HEAP */ | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if text heap is same as kernel heap, why need select ARCH_HAVE_TEXT_HEAP?