ORC-2203: Remove unused variables in docker/run-all.sh#2686
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
ORC-2203: Remove unused variables in docker/run-all.sh#2686dongjoon-hyun wants to merge 1 commit into
dongjoon-hyun wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove unused variable assignments (
URL,CLONE,MAKEDIR,VOLUME) fromdocker/run-all.sh.Why are the changes needed?
These variables are leftovers from before the per-OS build logic was extracted into
docker/run-one.sh, which defines and uses its ownCLONE/MAKEDIR/VOLUME. Inrun-all.sh, they are never referenced; the build loop invokes./run-one.sh $1 $2 $buildwith the positional arguments directly.URLis also removed because it was only referenced by the unusedCLONE. TheGITHUB_USER=$1andBRANCH=$2assignments are kept as documentation of the expected arguments.How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5