fix(core): validate writer batch schema#70
Open
QuakeWang wants to merge 2 commits into
Open
Conversation
Reject record batches whose field names, types, or nullability do not match the writer schema before using the cached column map. This prevents same-typed reordered Arrow batches from silently writing values under the wrong column names. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Do not reject an incoming batch solely because its field metadata is nullable while the writer schema is non-nullable. Keep the actual non-null contract enforced by the existing null-count check so PyArrow batches with nullable field metadata can still write when they contain no nulls. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MosaicWriter builds
batch_col_mapfrom the initial Arrow schema, butwrite_batchpreviously only checked column count and non-nullable null counts. A later batch with the same number of same-typed columns but reordered field names could be accepted and written through the stale column map, silently storing values under the wrong column names.This patch validates each incoming batch against the writer schema before using
batch_col_map: field name, logical type, and nullability must match. It also adds a regression test for the same-typed reordered-column case.