[core] Implement withFilter for TagsTable and FileKeyRangesTable#7874
Open
heye1005 wants to merge 1 commit into
Open
[core] Implement withFilter for TagsTable and FileKeyRangesTable#7874heye1005 wants to merge 1 commit into
heye1005 wants to merge 1 commit into
Conversation
Replace the placeholder TODO in TagsRead#withFilter and FileKeyRangesRead#withFilter with a read-side post-filter that evaluates the predicate on the materialized row before projection. For FileKeyRangesRead, partition / bucket / level are stripped out before storing the post-filter because they are already pushed down by FileKeyRangesScan; re-evaluating them on the materialized row would compare values of incompatible representations (e.g. a String literal vs the BinaryString in the row), mirroring the FilesTable behaviour introduced in apache#7791. Adds tests covering equal / in / not-equal / non-pushdown column / combined pushdown + post-filter scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Implement
withFilterforTagsRead/FileKeyRangesRead(wasTODO, predicates were silently ignored).FileKeyRangesReadexcludespartition/bucket/levelfrom the post-filter — already pushed down by scan, and re-evaluating them on the cast-to-string row breaks range predicates. Same pattern asFilesTable(#7791).Tests
TagsTableTest:=/IN/<>ontag_name, filter onsnapshot_id.FileKeyRangesTableTest:record_count/schema_id, combined predicate,partition < '{11}'regression.