[RIP-2] Add proxy admin online client query endpoint#10603
Draft
pilichoumao wants to merge 543 commits into
Draft
[RIP-2] Add proxy admin online client query endpoint#10603pilichoumao wants to merge 543 commits into
pilichoumao wants to merge 543 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR contains the RocketMQ implementation for RIP-2 Proxy Admin M1
online-client query through the generated public
apache.rocketmq.v2.ProxyAdminService:ListClientsDescribeClientListClientsByGroupListClientsByTopicThe public service runs on the independent Proxy admin gRPC listener and reuses
the lifecycle-fed read model, ACL, metrics, tracing, bounded query executor, and
error semantics in this branch.
Review Checkpoints
bde34c88ba575177b28e2854a8e7fa20ee628a82c372905ce927cf8957333e7ac07877f295fd7ec98c3098d51615189677118200955aeb6bdcbf90c0docs/en/rip2-proxy-admin-m1-review-runbook.mddocs/en/rip2-proxy-admin-m1-submission-package.mdContract And Isolation
PROXY_SCOPE_LOCAL_PROXY.PROXY_SCOPE_ALL_PROXIESandPROXY_SCOPE_PROXY_IDremain gated until thecommunity defines discovery, authorization, timeout, and pagination ownership.
MessagingServiceby service, port,server executor, query executor, and authentication pipeline.
Admin:proxy.admin.client; list operations requireLIST,describe requires
GET.from mutating a newer client session.
service work.
Verification
JDK 17 focused verification:
Broad proxy admin verification:
Package smoke:
Live release-distribution smoke:
Direct
grpcurlcalls reached all four public RPCs on 8082, verified liveNOT_FOUNDandBAD_REQUESTsemantics, and proved thatProxyAdminServiceisabsent from messaging port 8081 while
MessagingServiceand reflection areabsent from admin port 8082. Cleanup closed ports 9876, 8081, and 8082.
Authenticated release-distribution smoke (
dev/run_rip2_authenticated_smoke.sh)also exited
0: valid super-user signing returnedOK, unsigned and invalidsignatures returned
UNAUTHORIZED, and LIST-only / GET-only users enforced theexpected action split on
Admin:proxy.admin.client. Bounded cleanup closedports 9876, 8081, 8082, and 10911.
Core JaCoCo evidence:
Reproducible 1M-client, fixed-4-GiB deep full-range pagination evidence:
0.011 ms, max RSS1223.7 MiB0.843 ms, max RSS2792.3 MiBSubmission guard:
External Gates
org.apache.rocketmq:rocketmq-proto:2.2.0-rip2-SNAPSHOT; community APIacceptance and an official artifact are required before merge.
action_requiredandno check runs. Apache maintainer approval is required before jobs can start;
the strict
--require-github-checksgate remains red until they run and pass.JDK 17 may print JaCoCo 0.8.5 instrumentation stack traces. They are environment
noise only when Surefire reports zero failures/errors and Maven exits 0.