Wait for Tribes receiver startup#1023
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ChannelReceiver.ChannelCoordinatorwait for receiver readiness before reading or mutating the local member.NioReceiverafter the listener thread has entered listen mode and registered UDP reads when configured.Why
ChannelCoordinatorstarts the data receiver before copying receiver host/port details into the local member. For asynchronous receivers,start()can return before the receiver thread has finished its own start-up, leaving a small window where local-member state can be read or mutated too early.Testing
PATH=/opt/homebrew/opt/ant/bin:/opt/homebrew/Cellar/openjdk@17/17.0.19/bin:$PATH ant -Dtest.entry=org.apache.catalina.tribes.group.TestGroupChannelStartStop test