ZOOKEEPER-5020: Improve ZooKeeper website#2373
Conversation
146dc71 to
1a7bc1b
Compare
|
this is great, please have a conversation on dev@zookeeper.apache.org about the release process this is our current release process and it involves updating the website: |
Hi @eolivelli , There's already a discussion thread on dev@ with subject "[DISCUSS] The New ZooKeeper Website". |
There was a problem hiding this comment.
For installing Playwright in GH Actions you might find this useful:
https://playwright.dev/docs/ci-intro#setting-up-github-actions
PDavid
left a comment
There was a problem hiding this comment.
Many thanks, impressive work! 👍 I really like the new website.
I just found that we may miss some recently made updates, please see below.
| ## quit | ||
|
|
||
| Quit the CLI. |
There was a problem hiding this comment.
I think there we re some updates to this section under https://github.com/apache/zookeeper/pull/2358/changes not so long ago.
| enable Prometheus.io exporter. | ||
| - _metricsProvider.httpHost_ : | ||
| **New in 3.8.0:** Prometheus.io exporter will start a Jetty server and listen this address, default is "0.0.0.0" | ||
| - _metricsProvider.httpPort_ : |
There was a problem hiding this comment.
There were some updates to this section in https://github.com/apache/zookeeper/pull/2360/changes not so long ago.
| metricsProvider.httpPort=7000 | ||
| metricsProvider.httpsPort=4443 | ||
| ``` | ||
|
|
There was a problem hiding this comment.
A new section was added here not so long ago, see: https://github.com/apache/zookeeper/pull/2360/changes#diff-ba1b80ad29e393353d4dde0f0895bc2425d0ddaa558f5f81f21f8b19ee1dbf0d
| - _server_stats/srvr_ : | ||
| Server information. | ||
| Returns multiple fields giving a brief overview of server state. | ||
|
|
There was a problem hiding this comment.
I think we should add here shed_connections/shed which was added not so long ago:
|
Thanks for your review @PDavid |
|
Everything seems to be done. The PR for changes in the Once the final feedback is received, I will rebase the documentation changes. In the discussion thread we decided to architect the website in the following way:
|
PDavid
left a comment
There was a problem hiding this comment.
Many thanks Yurii! This looks good to me. 👍
I think what are pending before merging are:
- resolving conflicts with base branch
- add the missing doc updates which happened since on base branch
There was a problem hiding this comment.
Thanks for the detailed README. 👍
|
It seems the rat check will be broken because of the sitemap.xml file the website builds: I guess sitemap.xml has to be excluded from rat check. |
|
Interestingly the GitHub Actions were not run on the latest changes. Maybe it would worth to squash the commits? |
I can try that. Should I squash everything that we got on this branch into one commit? |
This is a draft PR of the new ZooKeeper website. The documentation can be found in the
README.mdfile under thezookeeper-websitedirectory. Thezookeeper-docsdirectory is removed.This PR might have more updates in the near future.
There is currently ongoing process of CI/CD integration into the Zookeeper repository. We're considering moving the released docs to another branch and just merge it with the website at a build time, since there's no point to pull a huge archive (1 GB) whenever you want to clone the repo. This discussion is currently ongoing, this app doesn't contain the released docs.
Website preview: https://zookeeper-website.vercel.app/
Previously, the master branch stored docs sources only of the current version, and the
websitebranch had the landing page source code plus the released docs. Currently, the master branch has the code of both documentation and landing page, it's all one app now.