fix(redis): reject TLS for Redis 5#3218
Draft
weicao wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## maya/redis-versioned-definitions-task97 #3218 +/- ##
=======================================================================
Coverage 0.00% 0.00%
=======================================================================
Files 155 156 +1
Lines 25027 25057 +30
=======================================================================
- Misses 25027 25057 +30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
weicao
force-pushed
the
maya/redis5-tls-unsupported-task105
branch
3 times, most recently
from
July 15, 2026 19:12
4abfe88 to
eda0d48
Compare
weicao
force-pushed
the
maya/redis5-tls-unsupported-task105
branch
from
July 15, 2026 20:42
eda0d48 to
8f1a9cb
Compare
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Redis 5.0.12 does not provide the TLS server/client capability used by the addon, but all three Redis 5 ComponentDefinitions advertised
spec.tls. Withtls: true, KubeBlocks injectedREDIS_CLI_TLS_CMD=--tls --insecurewhile the Redis 5 startup scripts launched a plaintext server. Exact runtime evidence showed all three shard Pods exhaust readiness attempts becauseredis-clirejects--tls; plaintext password-auth PING remained healthy.This failure happens before parent PR #3190 partial-join injection, so it is a separate capability-contract bug. See #3221.
Solution
spec.tlsfrom Redis 5 data, cluster, and sentinel ComponentDefinitions;1.2.0-alpha.5and Redis 5/6 slot-owner routing from parent PR fix(redis): version definitions and recover restored replication #3190;This PR is stacked on PR #3190 exact
31e4a0950244e4ecc86c1b3d6bccd8bcd9b13df9.TDD and validation
8f1a9cb53e265da321ac136b01ad80f51daadaa2; treed50c6f4d45075b9f7b0200feda17035c5452a31d.1/0; macOS Bash 3:1/0.28/0.552/0.git diff --check, Helm lint, Helm template, alpha.5 render and routing: PASS.Review focus
31e4a095.Runtime boundary
All older alpha.2/alpha.3/alpha.4 runtime evidence belongs to older source identities and does not transfer. Exact alpha.5 runtime is N=0. Max now owns fresh exact-head validation for Redis 5
tls:truerejection with Pod=0, Redis 5 password-only partial-join/restart, unchanged Redis 6/7/8 TLS+password/ACL behavior, and the shared shard-expansion contract. This source/render proof is not runtime PASS or release-ready.Fixes #3221