fix: correct reclaim_request counter adjustment in Apify request queue clients#973
Draft
vdusek wants to merge 4 commits into
Draft
fix: correct reclaim_request counter adjustment in Apify request queue clients#973vdusek wants to merge 4 commits into
vdusek wants to merge 4 commits into
Conversation
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 89.90% 90.10% +0.20%
==========================================
Files 49 49
Lines 3091 3093 +2
==========================================
+ Hits 2779 2787 +8
+ Misses 312 306 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
changed the title
…t-returns-handled-requests # Conflicts: # tests/unit/storage_clients/test_apify_request_queue_client.py
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix handled-request bookkeeping in the Apify request queue clients.
reclaim_requestcounter adjustment was dead code (both clients)When reclaiming a previously handled request, the metadata counters (
handled_request_count/pending_request_count) were never adjusted, so they drifted.Root cause: The guard
if request.was_already_handled and ...readwas_already_handled(a computed property equal tohandled_at is not None) afterrequest.handled_athad just been set toNone, so it was alwaysFalse.Fix: Capture
was_already_handledbefore clearinghandled_at, then use the captured value in the counter-adjustment condition. Applied to both the single and shared clients. Includes a regression test parametrized over both clients.