fix: redirect input key in all file-system key-value store operations#976
Draft
vdusek wants to merge 1 commit into
Draft
fix: redirect input key in all file-system key-value store operations#976vdusek wants to merge 1 commit into
vdusek wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #976 +/- ##
==========================================
+ Coverage 89.91% 89.94% +0.02%
==========================================
Files 49 49
Lines 3085 3102 +17
==========================================
+ Hits 2774 2790 +16
- Misses 311 312 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only
get_valuemapped the logical input key (INPUT) to the actual input file on disk (e.g.INPUT.json).set_value,record_exists,delete_value, andget_public_urloperated on the raw key, soset_value('INPUT', ...)wrote a second input file and reopening the store raisedRuntimeError('Only one input file is allowed...'), breakingActor.get_input()in local dev.The input-key redirect is now extracted into a shared
_resolve_input_keyhelper and applied to every key-addressing record method, so they all target the single input file consistently.