Skip to content

fix: redirect input key in all file-system key-value store operations#976

Draft
vdusek wants to merge 1 commit into
masterfrom
fix/fs-kvs-input-redirect
Draft

fix: redirect input key in all file-system key-value store operations#976
vdusek wants to merge 1 commit into
masterfrom
fix/fs-kvs-input-redirect

Conversation

@vdusek

@vdusek vdusek commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Only get_value mapped the logical input key (INPUT) to the actual input file on disk (e.g. INPUT.json). set_value, record_exists, delete_value, and get_public_url operated on the raw key, so set_value('INPUT', ...) wrote a second input file and reopening the store raised RuntimeError('Only one input file is allowed...'), breaking Actor.get_input() in local dev.

The input-key redirect is now extracted into a shared _resolve_input_key helper and applied to every key-addressing record method, so they all target the single input file consistently.

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jun 12, 2026
@vdusek vdusek self-assigned this Jun 12, 2026
@github-actions github-actions Bot added this to the 142nd sprint - Tooling team milestone Jun 12, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Jun 12, 2026
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.94%. Comparing base (2cc5602) to head (e9a3d3c).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...ge_clients/_file_system/_key_value_store_client.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #976      +/-   ##
==========================================
+ Coverage   89.91%   89.94%   +0.02%     
==========================================
  Files          49       49              
  Lines        3085     3102      +17     
==========================================
+ Hits         2774     2790      +16     
- Misses        311      312       +1     
Flag Coverage Δ
e2e 36.07% <62.50%> (+0.09%) ⬆️
integration 56.99% <81.25%> (+0.01%) ⬆️
unit 78.82% <93.75%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants