ci: Add Impit HTTP client to scheduled E2E templates matrix#1886
Merged
ci: Add Impit HTTP client to scheduled E2E templates matrix#1886
Conversation
The e2e template test parametrization and the project template CLI both support the impit HTTP client, but the scheduled CI matrix only exercised httpx and curl-impersonate, leaving the impit variant untested. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
added
t-tooling
vdusek
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1886 +/- ##
==========================================
- Coverage 92.71% 92.70% -0.01%
==========================================
Files 161 161
Lines 11356 11356
==========================================
- Hits 10529 10528 -1
- Misses 827 828 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The e2e template test parametrization and the project template CLI both already support the
impitHTTP client, but the scheduled CI matrix inon_schedule_tests.yamlonly exercisedhttpxandcurl_impersonate, leaving theimpitvariant untested.This PR adds
"impit"to thehttp-clientmatrix so the daily scheduled run covers all three HTTP client variants the templates ship with.Matrix size goes from 7×2×3 = 42 jobs to 7×3×3 = 63 jobs (
max-parallelstays at 12).