fix: avoid duplicate final crawler persistence#3866
Open
AkhilTrivediX wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid duplicate final persistence during
BasicCrawler.run()shutdown.SessionPool.teardown()from writing the same state a second time.Root cause
The shutdown path emitted
PERSIST_STATE, then directly persisted the session pool and statistics again. A crawler-owned event manager emitted another final event as it closed, which added a second write for statistics.Validation
corepack yarn vitest run test/core/crawlers/basic_crawler.test.ts --silent(70 passed)corepack yarn eslint packages/core/src/session_pool/session_pool.ts packages/basic-crawler/src/internals/basic-crawler.ts test/core/crawlers/basic_crawler.test.tscorepack yarn tsc-check-testscorepack yarn biome format --write ...git diff --checkFixes #3167