Skip to content

docs: align CLAUDE.md, CONTRIBUTING.md, and CHANGELOG with pnpm migration#233

Merged
jancurn merged 3 commits into
mainfrom
claude/review-pr-npm-docs-6EnXs
May 11, 2026
Merged

docs: align CLAUDE.md, CONTRIBUTING.md, and CHANGELOG with pnpm migration#233
jancurn merged 3 commits into
mainfrom
claude/review-pr-npm-docs-6EnXs

Conversation

@jancurn
Copy link
Copy Markdown
Member

@jancurn jancurn commented May 11, 2026

Summary

Follow-up to #232 (pnpm migration). Doc-only updates so the contributor workflow we describe matches the packageManager: pnpm@10.33.4 setup actually in the repo.

  • CLAUDE.md — replace npm install / npm run build / npm test / npm link / npm run lint / npm run release snippets with their pnpm equivalents. References to npm publish (the registry action, not a script) are kept as-is.
  • CONTRIBUTING.md — same npm → pnpm swap across dev setup, testing, and release sections. Also:
    • Short note about the 24h minimumReleaseAge quarantine, so contributors aren't surprised when a fresh dependency bump appears "stuck".
    • Fix stale references: keytar@napi-rs/keyring, and the outdated mcpc <url> session @name syntax → mcpc connect <url> @name.
    • Trim the architecture overview (~130 lines of protocol / IPC / lifecycle detail) that duplicated CLAUDE.md and was already rotting. Replaced with a high-level module map plus a pointer to CLAUDE.md for the deep dive. Net: 244 → 134 lines.
  • CHANGELOG.md — add a Security entry under [Unreleased] calling out the 24-hour package quarantine (minimumReleaseAge: 1440) and clarifying that installing @apify/mcpc from npm is unaffected (end users can still use npm/pnpm/bun).

Refs #232.

Test plan

  • CI green (lint/build/test on pnpm)
  • CLAUDE.md and CONTRIBUTING.md no longer reference npm run … for dev scripts (only npm publish for the registry action remains)
  • CONTRIBUTING.md no longer references keytar or the old session @name CLI syntax
  • CHANGELOG.md [Unreleased] → Security entry reads clearly for end users

Generated by Claude Code

claude added 3 commits May 11, 2026 16:58
Refs #232

- Replace npm with pnpm in CLAUDE.md dev/release workflow snippets
  (install, build, test, link, lint, format, release).
- Add a Security entry to CHANGELOG noting the 24-hour package
  quarantine (`minimumReleaseAge: 1440`) introduced with the pnpm
  migration to reduce supply-chain attack risk.
Refs #232

- Replace npm with pnpm across dev setup, testing, and release sections
- Add a short note on the 24h minimumReleaseAge supply-chain quarantine
  so contributors aren't surprised when a fresh dependency bump waits
- Fix stale references: keytar → @napi-rs/keyring, and the outdated
  `mcpc <url> session @name` CLI syntax in the session-lifecycle example
- Trim the architecture overview section: the protocol/IPC/lifecycle
  detail duplicated CLAUDE.md and was already rotting. Replaced with a
  high-level module map plus a pointer to CLAUDE.md for the deep dive.
@jancurn jancurn changed the title docs: update CLAUDE.md and CHANGELOG for pnpm migration docs: align CLAUDE.md, CONTRIBUTING.md, and CHANGELOG with pnpm migration May 11, 2026
@jancurn jancurn merged commit aa4b820 into main May 11, 2026
6 checks passed
@jancurn jancurn deleted the claude/review-pr-npm-docs-6EnXs branch May 11, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants