-
Notifications
You must be signed in to change notification settings - Fork 40
Add latest Rubies and Rails to CI matrix #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
willnet
wants to merge
6
commits into
apotonick:master
Choose a base branch
from
willnet:add-latest-rubies-and-rails-to-ci-matrix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8f31cf2
Add Ruby3.2, 3.3, 3.4 and Rails7.2, 8.0 to CI matrix
willnet ffb13a8
Fix tests cause changing ruby 3.4 hash inspect style
willnet 139ebd9
Change the tests using normalize_inspect to use the `assert_equal exp…
willnet 65c0713
Replace normalize_inspect with Trailblazer::Core::Utils.inspect
willnet 73e8752
Add Active Record 8.1 and Ruby 4.0 to CI matrix
willnet 8827d0e
Update actions/checkout to v6
willnet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,78 @@ | ||
| name: CI | ||
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ruby: [2.6] | ||
| active_record: [5.2, 6.0] | ||
| dry_types: [1.0, 1.2] | ||
|
|
||
| ruby: ['2.6'] | ||
| active_record: ['5.2', '6.0'] | ||
| dry_types: ['1.0', '1.2'] | ||
| include: | ||
| - ruby: 2.7 | ||
| active_record: 6.1 | ||
| dry_types: 1.5 | ||
| # Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0' | ||
| - ruby: '2.7' | ||
| active_record: '6.1' | ||
| dry_types: '1.6' | ||
| - ruby: '2.7' | ||
| active_record: '7.0' | ||
| dry_types: '1.6' | ||
| - ruby: '2.7' | ||
| active_record: '7.1' | ||
| dry_types: '1.6' | ||
| - ruby: '3.0' | ||
| active_record: 6.1 | ||
| dry_types: 1.5 | ||
| - ruby: 3.1 | ||
| active_record: 7.0.1 | ||
| dry_types: 1.5 | ||
| active_record: '6.1' | ||
| dry_types: '1.6' | ||
| - ruby: '3.0' | ||
| active_record: '7.0' | ||
| dry_types: '1.6' | ||
| - ruby: '3.0' | ||
| active_record: '7.1' | ||
| dry_types: '1.6' | ||
| - ruby: '3.1' | ||
| active_record: '7.0' | ||
| dry_types: '1.6' | ||
| - ruby: '3.1' | ||
| active_record: '7.1' | ||
| dry_types: '1.6' | ||
| - ruby: '3.1' | ||
| active_record: '7.2' | ||
| dry_types: '1.6' | ||
| - ruby: '3.2' | ||
| active_record: '7.0' | ||
| dry_types: '1.6' | ||
| - ruby: '3.2' | ||
| active_record: '7.1' | ||
| dry_types: '1.6' | ||
| - ruby: '3.2' | ||
| active_record: '7.2' | ||
| dry_types: '1.6' | ||
| - ruby: '3.2' | ||
| active_record: '8.0' | ||
| dry_types: '1.6' | ||
| - ruby: '3.3' | ||
| active_record: '7.1' | ||
| dry_types: '1.6' | ||
| - ruby: '3.3' | ||
| active_record: '7.2' | ||
| dry_types: '1.6' | ||
| - ruby: '3.3' | ||
| active_record: '8.0' | ||
| dry_types: '1.6' | ||
| - ruby: '3.4' | ||
| active_record: '7.2' | ||
| dry_types: '1.6' | ||
| - ruby: '3.4' | ||
| active_record: '8.0' | ||
| dry_types: '1.6' | ||
|
|
||
| runs-on: ubuntu-latest | ||
| env: | ||
| ACTIVERECORD: ${{ matrix.active_record }} | ||
| DRY_TYPES: ${{ matrix.dry_types }} | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
| # bundler-cache: true # runs 'bundle install' and caches installed gems automatically | ||
| - run: ACTIVERECORD=${{ matrix.active_record}} DRY_TYPES=${{ matrix.dry_types }} bundle install | ||
| - run: ACTIVERECORD=${{ matrix.active_record}} DRY_TYPES=${{ matrix.dry_types }} bundle exec rake | ||
| - uses: actions/checkout@v5 | ||
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
| - run: bundle install | ||
| - run: bundle exec rake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, we have this https://github.com/trailblazer/trailblazer-core-utils/blob/master/lib/trailblazer/core/utils/inspect.rb#L14 which we could use here, but I will test your version! 💚
Would you mind making the tests
assert_equal asserted, expected?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I changed only the parts related to this diff to use the
assert_equal expected, actualformat. Let me know if you want me to update all the other tests as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apotonick Any thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @willnet, thanks! I tested your
gsubmagic! 🎉 I will releasetrailblazer-core-utilssoon and we can start using ourinspecthelper here. Are you happy to change the tests accordingly?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apotonick Done! 😃