Add CIDR and domain pattern matching as utilities#44
Open
kpodosin wants to merge 1 commit into
Open
Conversation
tfpauly
reviewed
Jul 6, 2026
| extension Endpoint { | ||
| /// Returns true if this endpoint matches `pattern`. `"*"` matches all endpoints. Host endpoints | ||
| /// are matched by hostname; address endpoints are matched by IP address or CIDR block. | ||
| func matchesProxyPattern(_ pattern: String) -> Bool { |
Collaborator
There was a problem hiding this comment.
Probably this should be just "matchesPattern", not specific to proxies?
kpodosin
force-pushed
the
kpodosin/IPAddress+CIDR
branch
from
7d74301 to
31fa22d
Compare
tfpauly
reviewed
Jul 6, 2026
| } | ||
|
|
||
| var inAddr = in_addr() | ||
| guard inet_pton(AF_INET, addrString, &inAddr) == 1 else { return nil } |
Collaborator
There was a problem hiding this comment.
Let's remove any use of inet_pton, in_addr, etc. We should make this pure swift and standalone, with no platform dependencies.
tfpauly
reviewed
Jul 6, 2026
| var in6Addr = in6_addr() | ||
| guard inet_pton(AF_INET6, String(parts[0]), &in6Addr) == 1 else { return nil } | ||
|
|
||
| let rawNet = withUnsafeBytes(of: in6Addr) { |
tfpauly
reviewed
Jul 6, 2026
|
|
||
| // MARK: - CIDR parsing | ||
|
|
||
| #if !NETWORK_STANDALONE |
Collaborator
There was a problem hiding this comment.
Let's remove this check and not rely on inet_ functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds to Utilities/IPAddress+CIDR:
Adds tests for above in SwiftNetworkCIDRTests