Move SHIM_CRYPTO_SPAN_APIS to a trait that disables the shim#45
Open
agnosticdev wants to merge 8 commits into
Open
Move SHIM_CRYPTO_SPAN_APIS to a trait that disables the shim#45agnosticdev wants to merge 8 commits into
agnosticdev wants to merge 8 commits into
Conversation
tfpauly
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For projects that want to take advantage of the new Crypto Span APIs on Mac they should be able to do so without manually altering the project. For example right now there is a build flag that would manually need to be removed. This change moves the
SHIM_CRYPTO_SPAN_APISflag to a trait named:DISABLE_SHIM_CRYPTO_SPAN_APISand flips the polarity on it so it will be on by default and then when it needs to be disabled for performance sensitive cases the trait can be passed in to disable this path.