Skip to content

Feat/corporate email policy #3085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarshMN2345 merged 6 commits into from
Jun 12, 2026
+42 −5
Merged

Feat/corporate email policy #3085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2b63cd3
feat: add corporate email policy toggle to auth security settings
HarshMN2345 Jun 11, 2026
27ac976
fix: rename label to Deny non-corporate emails
HarshMN2345 Jun 11, 2026
7e22208
fix: use Require corporate emails label for better UX
HarshMN2345 Jun 11, 2026
984a55a
fix: use Deny non-corporate emails label for consistency
HarshMN2345 Jun 11, 2026
18f94ed
fix: use Require corporate emails label and show blocked email example
HarshMN2345 Jun 11, 2026
785b589
fix: use Deny non-corporate emails label
HarshMN2345 Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/actions/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ export enum Submit {
AuthAliasedEmailsUpdate = 'submit_auth_aliased_emails_update',
AuthDisposableEmailsUpdate = 'submit_auth_disposable_emails_update',
AuthFreeEmailsUpdate = 'submit_auth_free_emails_update',
AuthCorporateEmailsUpdate = 'submit_auth_corporate_emails_update',
AuthSessionAlertsUpdate = 'submit_auth_session_alerts_update',
AuthMembershipPrivacyUpdate = 'submit_auth_membership_privacy_update',
AuthMockNumbersUpdate = 'submit_auth_mock_numbers_update',
Expand Down
3 changes: 2 additions & 1 deletion src/routes/(console)/project-[region]-[project]/auth/security/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
project={data.project}
denyAliasedEmailPolicy={data.denyAliasedEmailPolicy}
denyDisposableEmailPolicy={data.denyDisposableEmailPolicy}
denyFreeEmailPolicy={data.denyFreeEmailPolicy} />
denyFreeEmailPolicy={data.denyFreeEmailPolicy}
denyCorporateEmailPolicy={data.denyCorporateEmailPolicy} />
<SessionSecurity
project={data.project}
sessionAlertPolicy={data.sessionAlertPolicy}
Expand Down
8 changes: 6 additions & 2 deletions src/routes/(console)/project-[region]-[project]/auth/security/+page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ type EnabledPolicy = {
const ProjectEmailPolicyId = {
DenyAliasedEmail: 'deny-aliased-email',
DenyDisposableEmail: 'deny-disposable-email',
DenyFreeEmail: 'deny-free-email'
DenyFreeEmail: 'deny-free-email',
DenyCorporateEmail: 'deny-corporate-email'
} as const;

type ProjectPolicy = Models.PolicyList['policies'][number] | EnabledPolicy;
Expand Down Expand Up @@ -72,6 +73,9 @@ export const load: PageLoad = async ({ depends, params }) => {
getDefaultEnabledPolicy(ProjectEmailPolicyId.DenyDisposableEmail),
denyFreeEmailPolicy:
(policiesById[ProjectEmailPolicyId.DenyFreeEmail] as EnabledPolicy) ??
getDefaultEnabledPolicy(ProjectEmailPolicyId.DenyFreeEmail)
getDefaultEnabledPolicy(ProjectEmailPolicyId.DenyFreeEmail),
denyCorporateEmailPolicy:
(policiesById[ProjectEmailPolicyId.DenyCorporateEmail] as EnabledPolicy) ??
getDefaultEnabledPolicy(ProjectEmailPolicyId.DenyCorporateEmail)
};
};
35 changes: 33 additions & 2 deletions ...outes/(console)/project-[region]-[project]/auth/security/updateSignupEmailSecurity.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,32 +18,38 @@
project,
denyAliasedEmailPolicy,
denyDisposableEmailPolicy,
denyFreeEmailPolicy
denyFreeEmailPolicy,
denyCorporateEmailPolicy
}: {
project: Models.Project;
denyAliasedEmailPolicy: EnabledPolicy;
denyDisposableEmailPolicy: EnabledPolicy;
denyFreeEmailPolicy: EnabledPolicy;
denyCorporateEmailPolicy: EnabledPolicy;
} = $props();

const getInitialAliasedEmails = () => denyAliasedEmailPolicy.enabled;
const getInitialDisposableEmails = () => denyDisposableEmailPolicy.enabled;
const getInitialFreeEmails = () => denyFreeEmailPolicy.enabled;
const getInitialCorporateEmails = () => denyCorporateEmailPolicy.enabled;

let savedAliasedEmails = $state(getInitialAliasedEmails());
let savedDisposableEmails = $state(getInitialDisposableEmails());
let savedFreeEmails = $state(getInitialFreeEmails());
let savedCorporateEmails = $state(getInitialCorporateEmails());

let authAliasedEmails = $state(getInitialAliasedEmails());
let authDisposableEmails = $state(getInitialDisposableEmails());
let authFreeEmails = $state(getInitialFreeEmails());
let authCorporateEmails = $state(getInitialCorporateEmails());

const hasChanges = $derived.by(() => {
const aliasedChanged = authAliasedEmails !== savedAliasedEmails;
const disposableChanged = authDisposableEmails !== savedDisposableEmails;
const freeChanged = authFreeEmails !== savedFreeEmails;
const corporateChanged = authCorporateEmails !== savedCorporateEmails;

return aliasedChanged || disposableChanged || freeChanged;
return aliasedChanged || disposableChanged || freeChanged || corporateChanged;
});

async function updateSignupEmailSecurity() {
Expand Down Expand Up @@ -80,9 +86,19 @@
trackEvent(Submit.AuthFreeEmailsUpdate);
}

if (authCorporateEmails !== savedCorporateEmails) {
currentSubmit = Submit.AuthCorporateEmailsUpdate;
await projectSdk.updateDenyCorporateEmailPolicy({
enabled: authCorporateEmails
});
hasAppliedServerChange = true;
trackEvent(Submit.AuthCorporateEmailsUpdate);
Comment on lines +91 to +95

@greptile-apps greptile-apps Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 SDK method updateDenyCorporateEmailPolicy may not exist in the pinned SDK

This PR adds a call to projectSdk.updateDenyCorporateEmailPolicy(...), but the SDK is still pinned at 82d2831 (no package.json or bun.lock changes are included). The three existing policy methods (updateDenyAliasedEmailPolicy, updateDenyDisposableEmailPolicy, updateDenyFreeEmailPolicy) were already present in that commit, but updateDenyCorporateEmailPolicy is only referenced in code added by this PR. Additionally, the policy ID deny-corporate-email is defined in the local ProjectEmailPolicyId constant rather than imported from the SDK's ProjectPolicyId enum, suggesting the SDK may not yet formally support this policy. With strict: false in the TypeScript config, a missing method would not surface as a compile error, so the form would appear to work normally but throw a runtime error on submit.

}

savedAliasedEmails = authAliasedEmails;
savedDisposableEmails = authDisposableEmails;
savedFreeEmails = authFreeEmails;
savedCorporateEmails = authCorporateEmails;
await invalidate(Dependencies.PROJECT);

addNotification({
Expand Down Expand Up @@ -148,6 +164,21 @@
</Layout.Stack>
</svelte:fragment>
</InputSwitch>

<InputSwitch
bind:value={authCorporateEmails}
id="authCorporateEmails"
label="Deny non-corporate emails">
<svelte:fragment slot="description">
<Layout.Stack gap="s">
<Typography.Text
>Only allow corporate email addresses. Blocks free providers and
disposable emails. For example: <Typography.Code
>user@gmail.com</Typography.Code>
</Typography.Text>
Comment thread
greptile-apps[bot] marked this conversation as resolved.
</Layout.Stack>
</svelte:fragment>
</InputSwitch>
</svelte:fragment>

<svelte:fragment slot="actions">
Expand Down