fix: emit og:image instead of og:image:url for images array#134
Open
nureddinhaji wants to merge 1 commit intoartiebits:masterfrom
Open
fix: emit og:image instead of og:image:url for images array#134nureddinhaji wants to merge 1 commit intoartiebits:masterfrom
nureddinhaji wants to merge 1 commit intoartiebits:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
imageshandler inopen-graph.svelteemitsog:image:urlinstead of bareog:imagefor theurlkey. Without the rootog:imagetag, most social platforms (Facebook, LinkedIn, Twitter/X, Discord, Slack) do not pick up the image.The
videoshandler already correctly special-casesurlto emitog:video, but theimageshandler was missing this same logic — a copy-paste inconsistency.Fix
Mirror the
videospattern: whenimgKey === "url", emitog:imageinstead ofog:image:url.{@const prop = imgKey === "url" ? "og:image" : \`og:image:\${imgKey}\`}One line changed.
References
og:image, notog:image:urlaloneog:imageis listed as one of the four required basic metadata propertiesTests
Updated the existing test to assert
og:imageinstead ofog:image:url. All 81 tests pass.