ci(release): repair workflow + migrate npm publish to OIDC Trusted Publishing [HELD: needs npm trusted-publisher setup]#9
Draft
MasonStation wants to merge 3 commits into
Conversation
fix(ci): repair release workflow startup failure + bump to 0.2.1 The homebrew-tap commit step embedded a multi-line `git commit -m` message whose blank line + column-0 `Assisted-By:` trailer terminated the YAML `run: |` block scalar early. That leaked `Assisted-By` as a stray top-level workflow key — lenient parsers accept it, but GitHub Actions rejects the unknown key and fails the whole file at startup. Every push since the v0.2 polish has produced a 0-second startup failure, and the v0.2.0 release never published to npm as a result. Collapse the message to two `-m` flags so it stays inside the block scalar. Bump @ashlr/stack(+core,+mcp) 0.2.0 -> 0.2.1 for the next release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> @
ci(release): publish via npm Trusted Publishing (OIDC) instead of a token npm now recommends Trusted Publishing for CI/CD over long-lived tokens, and all three packages already exist on npm so per-package trusted publishers can be configured. This removes the NPM_TOKEN secret entirely — the credential that expired, risked leaking, and hit EOTP on the v0.2.0 release. - publish-npm: drop the NPM_TOKEN gate, NODE_AUTH_TOKEN, and npm_otp plumbing (publish.sh never accepted --otp anyway — it would have died on the unknown arg); add `npm install -g npm@latest` for OIDC support (needs >= 11.5.1); keep provenance. Relies on workflow-level id-token: write (already present). - scripts/publish.sh is unchanged: `npm publish --access public` uses OIDC automatically when the trusted publisher is configured. Requires a one-time GitHub-Actions trusted publisher on each package at npmjs.com (org/repo = ashlrai/ashlr-stack, workflow file = release.yml). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> @
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Held back — do not merge yet. Blocked on a one-time manual step on npmjs.com: configure a GitHub-Actions trusted publisher for each of the three packages (
@ashlr/stack,@ashlr/stack-core,ashlr-stack-mcp) — org/repoashlrai/ashlr-stack, workflow filerelease.yml. Until that's live, OIDC publish can't authenticate. Merging this first would pointrelease.ymlat OIDC that isn't configured.What
Repairs the release pipeline and modernizes npm auth. Two commits:
git commit -min the Homebrew-tap job terminated the YAMLrun: |block scalar early, leaking anAssisted-Bystray top-level key. GitHub's schema validator rejected the whole file, so every push since the v0.2 polish produced a 0-second startup failure and the v0.2.0 npm publish never landed (npm stayed at 0.1.1). Collapsed to two-mflags. Also bumps@ashlr/stack(+core,+mcp)0.2.0 → 0.2.1.NPM_TOKEN(expired, hit EOTP under 2FA) in favor of per-package GitHub-Actions trusted publishers. Addsnpm install -g npm@latest(OIDC needs ≥ 11.5.1); keeps provenance. Relies on workflow-levelid-token: write(present).Verification
release.ymlparses cleanly; top-level keys are onlyname,on,permissions,concurrency,jobs— the strayAssisted-Bykey is gone.permissionsincludesid-token: write.NPM_TOKEN/NODE_AUTH_TOKENremoved (remaining mentions are explanatory comments).Scope
Split out of the bundled branch
fix/interactive-auth-spinner-hang(old PR #7). The CLI flag fix landed in #6; the interactive-auth fix landed in #8. This PR is only the release/CI work and is intentionally held.🤖 Generated with Claude Code