fix-rollbar (7424/464894116637): guard undefined week in playground handleFinish - #600
Open
astashovai wants to merge 1 commit into
Open
fix-rollbar (7424/464894116637): guard undefined week in playground handleFinish#600astashovai wants to merge 1 commit into
astashovai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?.) and early return guard tohandleFinishinprogramPreviewPlayground.tsxto prevent crash whenprogresses[weekIndex]is undefinedRollbar
https://app.rollbar.com/a/astashov/fix/item/liftosaur/7424/occurrence/464894116637
Decision
Fixed — the error is in our code and crashes the app during normal program preview/playground usage on Android.
Root Cause
In
ProgramPreviewPlayground, thehandleFinishcallback accessess.progresses[weekIndex].days[dayIndex]without checking ifs.progresses[weekIndex]exists. On Android (React Native), thePagerViewcan fire callbacks with aweekIndexthat is momentarily out of sync with theprogressesarray during state updates, causings.progresses[weekIndex]to beundefinedand the.daysaccess to throw a TypeError.Other code paths in the codebase already use optional chaining for the same access pattern (e.g.,
navModalPlaygroundUtils.ts,NavModalPlaygroundEditExercise.tsx,usePlaygroundModalBridges.ts).Test plan