Skip to content

Override skipping fields - #565

Merged
SentryMan merged 1 commit into
avaje:mainfrom
thatcomputerguy0101:force-write
Aug 7, 2026
Merged

Override skipping fields#565
SentryMan merged 1 commit into
avaje:mainfrom
thatcomputerguy0101:force-write

Conversation

@thatcomputerguy0101

Copy link
Copy Markdown
Contributor

For the first point of #558, this adds a forceSerialize method to JsonWriter to override skipping fields. This is implemented with a flag that is set when forceSerialize is called and reset when writeDeferredName is called, since all value writers and nested constructs make a call to writeDifferedName before writing their contents.

@SentryMan SentryMan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks simple enough

@SentryMan
SentryMan merged commit fe157a4 into avaje:main Aug 7, 2026
5 checks passed
@SentryMan

Copy link
Copy Markdown
Contributor

3.15-RC4

@SentryMan SentryMan added the enhancement New feature or request label Aug 7, 2026
@SentryMan SentryMan added this to the 3.15 milestone Aug 7, 2026
@rbygrave

rbygrave commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

looks simple enough

That is NOT sufficient reason to merge. I am not happy.

@thatcomputerguy0101

Copy link
Copy Markdown
Contributor Author

Some other projects I've worked on have a 24h minimum open PR window. You might want to consider that here.

@rbygrave

rbygrave commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Some other projects I've worked on have a 24h minimum open PR window. You might want to consider that here.

Absolutely not - totally wrong thinking there @thatcomputerguy0101 !!!

Firstly this to me is an incredibly important library, it's not just a little dependency on the side but it is an infrastructure style dependency and operates where ever JSON is used. If you are part of the java ecosystem that is moving away from reflection and towards ahead-of-time then avaje-jsonb can be considered extremely important.

The ask of us is to maintain this library at a level of excellence and not just for today or tomorrow but for the next 15 years. We as maintainers have to feel the weight of responsibility that comes with that. Many many people and projects are wanting us to be excellent maintainers and for a long time - because avaje-jsonb will be a key infrastructure dependency and a long lived dependency and because JSON is almost everywhere you look.

Feel and understand the weight of responsibility that we have here and what is being asked of us, what I am asking of us. We need to be excellent and excellent over a long period of time.

@rbygrave

rbygrave commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Absolutely not - totally wrong thinking there @thatcomputerguy0101 !!!

Apologies @thatcomputerguy0101 . I totally misread what you said and read it the other way - my bad.

24h minimum

Yeah ok, got it.

@rbygrave

rbygrave commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

looks simple enough

This is a mistake I have made too many times myself. As the maintainer of ebean orm that is just shy of 20 years as an open source project, a lot of the regrets come in the form of something that looks simple enough or useful enough but years down the track become a regret.

I should also say @SentryMan that you have been excellent with all these avaje projects. To me I'd also say that we often think differently and see different solutions and pros/cons of approaches, and to me that is a massive help to these projects resulting in better quality solutions. Its just with long lived libraries when we need feel that weight of a 15 year horizon and being excellent over a long period. Hence, we always try and maintain discipline on the decision making.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants