fix: make sidebar/drawer/modal usable on the canvas#65
Merged
Conversation
Seed overlay components open on drop, measure the painted panel for selection, register x-sidebar as a flow container, flatten modal/drawer overlays in the editor so they're droppable, and register their events. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlay components were broken on the canvas: they dropped invisible, the selection border traced the host box instead of the painted panel, and modal/drawer couldn't be dropped into at all.
Fixes
meta/probes), with a host fallback when the panel is collapsed (empty docked sidebar).meta/slots), seededwidth:100%, and placement moved from:top-full-widthto:flow.:host{display:contents}, fixed panel) flattened for the editor only via the public::part()API so they have a box and are droppable. Scoped to.canvas-host; never exported.Gates
clj-kondo 0/0 · cljfmt clean · 863 tests, 0 failures · release 0 warnings.
🤖 Generated with Claude Code