ci: verify all PR checks before triggering auto-merge - #6556
Open
rafaelespinoza wants to merge 4 commits into
Open
ci: verify all PR checks before triggering auto-merge#6556rafaelespinoza wants to merge 4 commits into
rafaelespinoza wants to merge 4 commits into
Conversation
Automated Quality ChecksSkipped — this PR does not modify This is expected for maintenance, documentation, or workflow PRs. |
rafaelespinoza
marked this pull request as ready for review
August 5, 2026 04:09
Contributor
Author
|
@avelino, could you please have a look at this one when you have some time? Thanks |
1 task
Contributor
Author
Automated Quality ChecksSkipped — this PR does not modify This is expected for maintenance, documentation, or workflow PRs. |
Fixes avelino#6550. The `auto-merge` job in `pr-quality-check.yaml` relies on native `needs` gates, which only evaluate jobs inside the same workflow file. Consequently, failures in external workflows (such as `tests.yaml`) were not visible to this job, allowing PRs to auto-merge despite failing tests. This change adds a pre-check step using `gh pr checks` that: 1. Verifies that the evaluated HEAD commit matches the current commit. Intended to address race conditions that may occur due to new pushes. 2. Filters out the active workflow run using `github.run_id`. 3. Verifies all external PR checks are in a passing state (SUCCESS, SKIPPED, or NEUTRAL).
rafaelespinoza
force-pushed
the
ci-fix_auto_merge
branch
from
August 14, 2026 04:23
a45671b to
8fffbeb
Compare
Recase variables, outside values are UPCASED, while local to script variables are downcased. Add some extra print statements, I found them helpful for debugging. Print JSON for non passing checks, seems easier to read. Open to feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6550.
The
auto-mergejob inpr-quality-check.yamlrelies on nativeneedsgates, which only evaluate jobs inside the same workflow file.Consequently, failures in external workflows (such as
tests.yaml)were not visible to this job, allowing PRs to auto-merge despite failing
tests.
This change adds a pre-check step using
gh pr checksthat:Intended to address race conditions that may occur due to new pushes.
github.run_id.SKIPPED, or NEUTRAL).