fix: regression introduced in my previous commit + add guard#148
Merged
Conversation
6 tasks
Nyeriah
added a commit
that referenced
this pull request
May 30, 2026
OnBattlefieldPlayerLeaveZone stopped clearing the fake in #147, and the deferred OnPlayerUpdateZone path added alongside #148 has an InBattleground() guard that prevents the clear once the teleport lands on the BG map. The WG fake therefore persists into the BG, where it short-circuits both BalanceTeamsOnEntry (its IsPlayerFake guard) and SetFakeRaceAndMorph (same guard), and can desync bgTeamId from GetTeamId() -- most visibly when a player queues for a BG before WG war pops, gets faked Horde mid-queue, and lands on the Alliance queue-side with a Horde faction and visual. Clear any pre-existing fake at the top of ValidatePlayerForBG so the BG entry path re-evaluates against bgTeamId. The #147 timing concern does not apply here -- Battlefield::HandlePlayerLeaveZone has already finished by the time Battleground::AddPlayer runs on the new map. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.