Skip to content

feat: align radio layout and add unchecked hover state #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
isaquebock wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

feat: align radio layout and add unchecked hover state #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions packages/webkit/src/components/inputs/field-radio-block/field-radio-block.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
const cardClasses = cn(
selectableBlockCardClasses,
'flex cursor-pointer items-start gap-[var(--spacing-sm)] p-[var(--spacing-sm)]',
'data-[selected]:border-[var(--border-selected)] data-[selected]:bg-[var(--primary-selected)]',
'data-[selected]:border-[var(--border-selected)] data-[selected]:bg-[var(--bg-selected)]',
'data-[selected]:before:hidden data-[selected]:after:hidden',
'data-[disabled]:opacity-50'
)
Expand All @@ -92,6 +92,14 @@
:data-disabled="disabled || null"
:data-testid="`${testId}__card`"
>
<RadioButton
v-model="model"
:value="value"
:name="name"
:disabled="disabled"
:input-id="resolvedInputId"
:data-testid="`${testId}__control`"
/>
<div
:class="textsClasses"
:data-disabled="disabled || null"
Expand Down Expand Up @@ -124,14 +132,6 @@
<span :data-testid="`${testId}__helper-text`">{{ helperText }}</span>
</div>
</div>
<RadioButton
v-model="model"
:value="value"
:name="name"
:disabled="disabled"
:input-id="resolvedInputId"
:data-testid="`${testId}__control`"
/>
</div>
</label>
</template>
16 changes: 8 additions & 8 deletions packages/webkit/src/components/inputs/field-radio/field-radio.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,14 @@
:data-testid="testId"
:data-disabled="disabled || null"
>
<RadioButton
v-model="model"
:value="value"
:name="name"
:disabled="disabled"
:input-id="resolvedInputId"
:data-testid="`${testId}__control`"
/>
<div
:class="textsClasses"
:data-disabled="disabled || null"
Expand Down Expand Up @@ -106,13 +114,5 @@
<span :data-testid="`${testId}__helper-text`">{{ helperText }}</span>
</div>
</div>
<RadioButton
v-model="model"
:value="value"
:name="name"
:disabled="disabled"
:input-id="resolvedInputId"
:data-testid="`${testId}__control`"
/>
</label>
</template>
5 changes: 3 additions & 2 deletions packages/webkit/src/components/inputs/radio-button/radio-button.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,12 @@

const sharedClasses = [
...toggleControlClasses,
'group size-5 rounded-full border border-[var(--border-default)] bg-[var(--bg-surface)]'
'group size-5 rounded-full border border-[var(--border-default)] bg-[var(--bg-surface)]',
'[&:not([data-checked])]:hover:border-[var(--primary)] [&:not([data-checked])]:hover:before:opacity-0'
]

const checkedClasses =
'data-[checked]:border-[var(--primary)] data-[checked]:bg-[var(--primary)] data-[checked]:before:hidden data-[checked]:after:hidden'
'data-[checked]:border-[var(--primary)] data-[checked]:bg-[var(--primary)] data-[checked]:after:hidden'

const disabledClasses =
'data-[disabled]:pointer-events-none data-[disabled]:cursor-not-allowed data-[disabled]:border-[var(--border-default)] data-[disabled]:bg-[var(--bg-disabled)] data-[disabled]:opacity-50 data-[checked]:data-[disabled]:border-[var(--border-default)] data-[checked]:data-[disabled]:bg-[var(--bg-disabled)]'
Expand Down
Loading