feat: add mono photo schema#52
Merged
trim21 merged 1 commit intobangumi:masterfrom May 3, 2026
Merged
Conversation
Add the shared chii_subject_photos table used by character and person albums, and include it in the SQL load order and expected table checks. Also update character and person comment schemas with the related photo column required by photo-specific comments.
Contributor
Author
|
cc @trim21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Character and person album APIs in server-private need the dev database to expose the same mono photo schema that exists in the Bangumi database. Without these tables and columns, tests that pull schema/data from dev-env cannot exercise photo lists or photo-related comments.
Approach
Add the shared
chii_subject_photosschema used by character/person albums, and update the character/person comment schemas with their related photo columns. The new schema is registered in the SQL load order and expected table checks so rebuilds include it consistently.Validation
sql/is listed insql_script_load_order.txtgit diff --checkpython3 test.pybecause this local environment is missingpymysqland no MySQL test container was started