feat: add mono photo APIs

[everpcpc]

Summary

Add a shared mono-photo helper around chii_subject_photos, then wire character and person routes through the same list/detail/comment behavior. Photo comments reuse the existing comment service while carrying relatedPhotoID, so regular comments and photo-scoped comments stay in the same storage model without duplicating comment logic.

Scope

• Add character/person photo preview, list, detail, and photo comment endpoints
• Add Drizzle schema coverage for chii_subject_photos and related photo comment fields
• Add mono-photo response and request schemas, image conversion, and OpenAPI snapshot updates
• Add focused route coverage for character/person photo and photo comment flows

Validation

• pnpm tsc
• pnpm lint (passes with existing warning in lib/utils/index.ts:203)
• pnpm exec vitest run routes/index.test.ts -u
• pnpm exec vitest run routes/private/routes/character.test.ts routes/private/routes/person.test.ts -t 'photos|person comments'
• git diff --check
• npm run build

[codecov]

Codecov Report

❌ Patch coverage is 77.35849% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.40%. Comparing base (78f81eb) to head (efcd732).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
lib/comment.ts	48.00%	11 Missing and 2 partials ⚠️
lib/person/photo.ts	75.00%	2 Missing and 2 partials ⚠️
routes/private/routes/character.ts	88.00%	2 Missing and 1 partial ⚠️
lib/types/convert.ts	60.00%	1 Missing and 1 partial ⚠️
routes/private/routes/person.ts	92.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
+ Coverage   55.98%   56.40%   +0.41%     
==========================================
  Files         143      145       +2     
  Lines        6589     6686      +97     
  Branches     1462     1479      +17     
==========================================
+ Hits         3689     3771      +82     
- Misses       2200     2210      +10     
- Partials      700      705       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[trim21]

Code Review

整体结构很好，新 photo endpoints 和现有 character/person comment 模式一致，测试覆盖也全面。以下是几个需要关注的问题：

1. lib/comment.ts — create 中查询 parent 改成了 select() 全列

原代码只 select 了 { id, state }，PR 改成了 select() 拉全部列。建议保持最小列集，如果需要 relatedPhotoID，在 hasRelatedPhoto() 分支内单独查询或做类型收窄，避免 'relatedPhotoID' in parent 这种 runtime 检查。

2. lib/comment.ts — Object.assign(reply, { relatedPhotoID }) 绕过类型系统

Object.assign 绕过了 $inferInsert 的类型检查。虽然运行时能工作（hasRelatedPhoto() 保证了表有字段），但违反严格类型原则。建议在 hasRelatedPhoto() 分支内构造带 relatedPhotoID 的 insert 对象，或使用类型断言。

3. lib/comment.ts — if (relatedPhotoWhere) 永远为 true

Drizzle 的 op.and() 总是返回 truthy 值，这个 if 不会走 else。可以直接赋值 where = op.and(where, op.eq(...)) 去掉条件。

4. lib/comment.ts — photo type 魔数 1 和 2

create 中 op.eq(schema.chiiSubjectPhotos.type, 1) 和 type, 2 应该导入使用已定义的 MonoPhotoType.Character / MonoPhotoType.Person，而不是硬编码。

5. lib/person/photo.ts — MonoPhotoType 缺少 as const

export const MonoPhotoType = Object.freeze({
  Character: 1,
  Person: 2,
});

没有 as const 会导致 MonoPhotoType 类型退化为 number。规范要求 Object.freeze({ ... } as const)。（注：项目中已有的 freeze 常量也有同样问题，可以另开 PR 批量修复）

6. lib/comment.ts — 'relatedPhotoID' in d runtime 检查不够类型安全

relatedPhotoID: 'relatedPhotoID' in d ? d.relatedPhotoID : undefined,

用 in 检查如果后续有表新增同名字段但语义不同会错误匹配。建议用 this.hasRelatedPhoto() 做类型守卫。

7. lib/types/convert.ts — photo.type === 1 硬编码

同第 4 点，应该使用 MonoPhotoType.Character。当前代码如果新增 photo type 3 会默认走 'person' 分支。

8. lib/images.ts — baseMonoPhotoPath 缺少尾部 /

const baseMonoPhotoPath = `pic/photos`;

其他 base path（如 basePersonImagePath = 'pic/crt/l'）已包含子路径，baseMonoPhotoPath 需要拼接时再加 /，风格不一致。