docs(migration): add missing notifications.md for MiniKit to Farcaster - #58
Open
faisalnugroho wants to merge 1 commit into
Open
docs(migration): add missing notifications.md for MiniKit to Farcaster#58faisalnugroho wants to merge 1 commit into
faisalnugroho wants to merge 1 commit into
Conversation
The mapping.md file referenced NOTIFICATIONS.md in two places for server-side notification implementation, but the file didn't exist. Anyone following the migration guide would hit a broken link. Created notifications.md with: - Webhook registration steps - User notification token storage - Server-side send implementation - Client-side trigger pattern - Key differences table from MiniKit - Security notes Also fixed the link casing to match the actual filename. Fixes base#30
Collaborator
🟡 Heimdall Review Status
|
Author
|
Hi! Following up on this docs PR. This PR adds the missing notifications.md migration doc for the MiniKit to Base App transition, fixing a broken internal reference in the migration guide. All CI checks pass (StepSecurity ✅). Would love to get your review when you have a moment. Thanks! |
Author
|
Hi! I'd love to get this PR reviewed when you have a moment. This PR addresses add missing notifications.md for MiniKit to Farcaster migration. Happy to make any adjustments based on your feedback. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the missing
notifications.mdfile thatmapping.mdreferences for server-side notification implementation during MiniKit to Farcaster migration.The problem
mapping.mdreferencesNOTIFICATIONS.mdin two places (lines 412 and 452):But that file doesn't exist. Anyone following the migration guide for the notification section hits a dead link and has to figure out the Farcaster notification API on their own.
What's in the new file
Created
notifications.mdwith:Also fixed the link casing (
NOTIFICATIONS.md→notifications.md) to match the actual filename.Fixes #30