Add o1.exchange trading plugin#70
Open
JerryPan2718 wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
🟡 Heimdall Review Status
|
stephancill
reviewed
Jun 4, 2026
Collaborator
stephancill
left a comment
There was a problem hiding this comment.
Thanks for the submission. The documented endpoints resolve and the response shapes match, but the Permit2 signing flow has a blocking issue:
Required
- The Permit2 flow string-replaces a fixed 65-byte
SIGNATURE_PLACEHOLDERinunsigned.datawith the signature. This only holds for EOA signatures. Base smart-account signatures (ERC-1271/6492) are variable-length (unbounded; >200 bytes in practice) and the signature is ABI-encoded as a dynamicbytesfield with a length prefix and offset. Splicing such a signature into a fixed 65-byte slot produces malformed calldata, so the flow fails for smart-contract wallets — the common Base account type. Encode the signature as dynamicbytes(and support ERC-1271 verification), or have the build endpoint accept the signature and re-encode server-side.
Minor
- Submitting the order through
send_callsbypasses o1's/order/completeprivate-mempool relay, somevProtectiondoes not apply to these submissions. State this so it isn't presented as MEV-protected. - The API-token URL is inconsistent across sections; use the one that resolves.
## Authshould document token lifetime/refresh, and## Submissionshould state thevaluehex-wei contract.- Consider adding
low-liquiditytoriskfor arbitrary-token / pool-targeted trades.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http-apiintegration →send_callsTest plan
api.o1.exchangeis reachable and/orderendpoint returns expected unsigned tx shapesend_callsmapping:{ to, data, value }fromunsignedobject,gasLimit/chainIdstripped🤖 Generated with Claude Code