fix: improve CRA send batch failure handling and UI feedback#387
Merged
Conversation
Record job failures on batch system comments and system_error status, invoke onFailure when send setup fails, show batch numbers in send messages, and hide the running banner when the job fails or completes.
plakkara-bc
approved these changes
Jun 25, 2026
Reload batch requests and details when a send job fails so updated system_error status and system comments appear without a manual refresh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes CRA send job failure handling so batches show the correct status and comments, UI messages use batch number, and the running banner clears when the job fails or completes.
What Changed
onFailurewhen send setup (onStart) failsHow to Test
send-cra-file.handler.spec.tsand related backend tests