Improve DomStack programmatic build testing support#251
Conversation
Coverage Report for CI Build 28271793017Coverage decreased (-0.6%) to 91.837%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
Fixes programmatic DomStack usage so relative copy paths are normalized consistently (stored as absolute paths) based on the src location rather than the process working directory.
Changes:
- Resolve
opts.copyentries to absolute paths in theDomStackconstructor. - Persist resolved copy paths back onto
this.opts.copyso downstream copy steps/watchers consume consistent absolute paths. - Simplify dest-containment validation to operate on already-resolved copy paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This is probably fine but only partially imements all suggestions in the parent issue. |
|
This only addresses the "The constructor does not resolve copy paths" issue. It also warrants a document README.md update and a jsdoc update for the public interface. |
fce6532 to
095edd5
Compare
Resolve programmatic copy paths, improve worker error context, add a testBuild helper, and migrate successful build fixtures to use isolated temporary destinations. Closes #234
4fe23ab to
a8c5b94
Compare
|
All issues addressed. |
This PR completes the programmatic API testing improvements tracked in #234.
Completed
copypaths passed to theDomStackconstructor to absolute paths from the current working directory, matching CLI--copybehavior.this.opts.copyso downstream build and watch copy steps receive consistent absolute paths.copypath behavior inREADME.mdand theDomStackOptsJSDoc.cause, stack, and attached metadata.testBuild(src, opts)helper for isolated programmatic test builds into temporary directories.testBuild()usage and adds fixture coverage for generated output reading, copy-option pass-through, and cleanup.Validation
node --test --test-reporter spec test-cases/page-build-errors/index.test.jsnode --test --test-reporter spec test-cases/test-build-helper/index.test.jsnpm run test:tscnpm run test:neostandardnpm run test:node-testnpm run test:installed-checkCloses #234