Add SonarQube analysis workflow#103
Conversation
bernardladenthin
had a problem deploying
to
startgate
GitHub Actions
Error
|
Review posted as inline comments. Key issues: missing SPDX header (project convention), unpinned sonar-maven-plugin version, and missing SONAR_HOST_URL env var for clarity. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| @@ -0,0 +1,36 @@ | |||
| name: SonarQube | |||
There was a problem hiding this comment.
The workflow file should include the SPDX license header to match the project's convention. Compare with other workflows in .github/workflows/ — they all include the Apache 2.0 header.\n\nsuggestion\n# SPDX-FileCopyrightText: 2014-2026 Bernard Ladenthin <bernard.ladenthin@gmail.com>\n#\n# SPDX-License-Identifier: Apache-2.0\n\nname: SonarQube\n",
true
| - name: Build and analyze | ||
| env: | ||
| SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} | ||
| run: mvn -B verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=bernardladenthin_streambuffer |
There was a problem hiding this comment.
The SonarQube Maven plugin version is not pinned. For consistency with the pinned action versions above (e.g., actions/checkout@v4.3.1), either:\n1. Pin the plugin version explicitly in pom.xml, or\n2. Specify the version in the Maven command\n\nAlso consider adding SONAR_HOST_URL as an environment variable for clarity — it defaults to SonarCloud, but explicitly setting it makes the intent clear.",
true
bernardladenthin
had a problem deploying
to
startgate
GitHub Actions
Error
…in toString() bufferLock is private final; the synthetic access$N bridge is a Java 8 compiler artifact from private inner classes accessing the private field. jcstress ConcurrentWriteRace confirms the synchronization is sound.
bernardladenthin
had a problem deploying
to
startgate
GitHub Actions
Error
|
2 participants
Summary
mainand pull requestspom.xmlto enable analysis integrationTest plan
Related issues / PRs
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdSECURITY.md)https://claude.ai/code/session_012WHHfb7tuYQkFz1YQ1BRmd