unify hx-on and hx-trigger modifier grammar#3798
Open
scriptogre wants to merge 2 commits into
Open
Conversation
- enable hx-on="eventSpec => code" syntax that supports all existing hx-trigger modifiers (e.g. [filter], once, delay, changed, from, etc.). - add new modifiers to both hx-on and hx-trigger: prevent, stop, halt, capture, passive, from:self, from:outside - remove undocumented dot modifiers (.prevent, .stop, .halt, .once, .self, .outside, .capture, .passive, .cc) from hx-on:event syntax - rename __onTrigger -> __onEvent - rename __parseTriggerSpecs -> __parseEventSpecs - remove hx-trigger queue modifier from docs (no-op in 4.0) - update tests, docs, and extension references
Change the grammar separator in hx-on="event => code" from => to ->.
This avoids visual ambiguity with JavaScript arrow functions that may
appear in the handler code.
Updated:
- src/htmx.js: indexOf('=>') → indexOf('->')
- test/tests/attributes/hx-on.js: all hx-on attribute values
- test/tests/ext/hx-live.js: hx-live helper tests using hx-on
- www docs: all examples and explanations in hx-on.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable
hx-on="eventSpec => code"syntax that supports all existinghx-triggermodifiers (e.g.[filter],once,delay,changed,from, etc.).add new modifiers to both hx-on and hx-trigger:
prevent,stop,halt,capture,passive,from:self,from:outsideremove undocumented dot modifiers (.prevent, .stop, .halt, .once, .self, .outside, .capture, .passive, .cc) from hx-on:event syntax
rename
__onTrigger->__onEventrename
__parseTriggerSpecs->__parseEventSpecsremove
hx-triggerqueue modifier from docs (no-op in 4.0)update tests, docs, and extension references