feat: add worker option for inline/main-thread runtime - #53
Open
hesam-oxe wants to merge 1 commit into
Open
Conversation
Added worker option to WebDemuxerOptions. When worker: false, no internal Worker is created, allowing safe use inside Web Workers. Streaming raises error in inline mode. Closes bilibili#51
Collaborator
|
@hesam-oxe Thanks for the PR, but worker: false won't work as-is — getFromWorker() rejects when there's no worker, so getAVPacket() etc. will all fail. The inline wasm execution path is missing. |
Author
|
@ForeverSc You're right — the inline wasm execution path is missing. I'll need to understand how the WASM module is loaded and executed Could you point me to:
I'll update the PR with a proper inline implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
workeroption toWebDemuxerOptionsto allow disabling theinternal Worker for use inside Web Workers.
Changes
workeroption (default:truefor backward compatibility)worker: false, no internal Worker is createdload()and non-streaming methods work in inline modeUsage