[PM-33046] Remove GetManyAbilities repo methods and cache interface#7960
Conversation
5796650 to
750c184
Compare
750c184 to
264cda5
Compare
Part of removing the legacy in-memory application cache system. Removes GetManyAbilitiesAsync from the organization/provider repository interfaces and their Dapper/EF implementations, deletes the IVCurrentInMemoryApplicationCacheService interface, and drops the obsolete EF integration test.
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This is step 3 of 4 in the stacked removal of the legacy in-memory application cache (PM-33046). It deletes the Code Review DetailsNo blocking findings.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7960 +/- ##
==========================================
+ Coverage 66.13% 66.60% +0.46%
==========================================
Files 2256 2276 +20
Lines 99392 99326 -66
Branches 8983 8978 -5
==========================================
+ Hits 65732 66154 +422
+ Misses 31409 30904 -505
- Partials 2251 2268 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎯 Objective
Part of removing the legacy in-memory application cache system (PM-33046).
Ticket: https://bitwarden.atlassian.net/browse/PM-33046
This is one atomic removal split into 4 stacked-by-dependency PRs, all based on
main. To keepmaincompiling and runtime-safe, they must merge in this order:events-di(Data Insights & Reporting) — remove DI consumer in Eventscore-services(Core / platform) — delete cache service impls + SharedWeb DIadmin-console-repos(Admin Console) — delete cache interface +GetManyAbilitiesAsyncrepo methodsdbops-drop-procs(DB Ops) — drop the stored procedures the Dapper code called👉 This PR is step 3 of 4. Do not merge before the steps above it.
📋 Code Changes
src/Core/AdminConsole/AbilitiesCache/IVCurrentInMemoryApplicationCacheService.cs— deletedsrc/Core/AdminConsole/Repositories/IOrganizationRepository.cs— removeGetManyAbilitiesAsyncsrc/Core/AdminConsole/Repositories/IProviderRepository.cs— removeGetManyAbilitiesAsyncsrc/Infrastructure.Dapper/AdminConsole/Repositories/OrganizationRepository.cssrc/Infrastructure.Dapper/AdminConsole/Repositories/ProviderRepository.cssrc/Infrastructure.EntityFramework/AdminConsole/Repositories/OrganizationRepository.cssrc/Infrastructure.EntityFramework/AdminConsole/Repositories/ProviderRepository.cstest/Infrastructure.EFIntegration.Test/AdminConsole/Repositories/OrganizationRepositoryTests.cs