feat: implement bundled load for pool v1 reserves and v2 emissions#82
Merged
feat: implement bundled load for pool v1 reserves and v2 emissions#82
Conversation
mootz12
requested changes
Mar 11, 2025
Comment on lines
+442
to
+446
| export class ReserveEmissions { | ||
| constructor( | ||
| public poolId: string, | ||
| public assetId: string, | ||
| public supplyEmissions: Emissions | undefined, | ||
| public borrowEmissions: Emissions | undefined | ||
| public supplyEmissions: Map<string, Emissions>, | ||
| public borrowEmissions: Map<string, Emissions> |
Contributor
There was a problem hiding this comment.
this seems over-optimized, as this object is quite confusing now.
IMO we should move forward with the V1 reserve loading optimization only
mootz12
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.