Conversation
Ryang-21
force-pushed
the
seperate-v2-events
branch
from
358d042 to
8156598
Compare
mootz12
previously approved these changes
Apr 7, 2025
mootz12
requested changes
Apr 10, 2025
| * | ||
| * @param res_emission_metadata - A vector of ReserveEmissionMetadata to update metadata to. | ||
| * | ||
| * @throws Will throw an error if the caller is not the admin or if the sum of ReserveEmissionMetadata shares is greater than 1. |
Contributor
There was a problem hiding this comment.
this is not true for V2.
Better to omit IMO since not a lot of new pools will be being created in v1 anymore
| * @param contractArgs.contract - The contract that will receive the flash loan callback. | ||
| * @param contractArgs.asset - The asset to be borrowed in the flash loan. | ||
| * @param contractArgs.amount - The amount to be borrowed in the flash loan. | ||
| * |
Contributor
There was a problem hiding this comment.
flash loan args are missing
requests: Array<Request>
from contract:
fn flash_loan(
e: Env,
from: Address,
flash_loan: FlashLoan,
requests: Vec<Request>,
) -> Positions;
Contributor
There was a problem hiding this comment.
thx for adding these - was a big testing gap
mootz12
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.