feat: add future reflector ledger entries for lengthy tx submissions#88
Merged
feat: add future reflector ledger entries for lengthy tx submissions#88
Conversation
mootz12
requested changes
Jul 2, 2025
|
|
||
| const newRoundTimestamp = roundTimestamp + 300_000n; | ||
|
|
||
| newReadEntries.push( |
Contributor
There was a problem hiding this comment.
this can cause a potentially problematic number of duplicate entries.
Most Blend V2 oracle calls invoke multiple price entries for a single asset index.
IE - assume asset index 1 is called, it would include the entries:
- price, asset 1, t_now
- price, asset 1, t_now - (1 * round_period)
- price, asset 1, t_now - (2 * round_period)
In this case, the logic should only include one additional entry,
-> price, asset 1, t_now + round_period
Ryang-21
force-pushed
the
reflector-oracle-entries
branch
from
1f11b1e to
fde6019
Compare
mootz12
previously approved these changes
Jul 7, 2025
mootz12
reviewed
Jul 7, 2025
| { | ||
| "name": "@blend-capital/blend-sdk", | ||
| "version": "3.0.1", | ||
| "version": "3.1.0", |
Contributor
There was a problem hiding this comment.
this is mostly for the minor version change in stellar-sdk
mootz12
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.