feat(actions): remove auto-commit option from actions#766
Open
matt2e wants to merge 1 commit into
Open
Conversation
Strip the per-action auto-commit toggle end-to-end. Actions now only execute their command and never create git commits. - UI: drop the auto-commit checkbox and `autoCommit` form state from the action editor, and remove the field from create/update/detection flows. - TS bindings: remove `autoCommit` from `ProjectAction`/`SuggestedAction` and the `createRepoAction`/`updateProjectAction` signatures, and delete the unused `ActionAutoCommitEvent`/`listenToActionAutoCommit`. - Tauri commands: drop the `auto_commit` parameter from `create_repo_action` and `update_project_action` in `lib.rs` and `web_server.rs`. - Store: remove `RepoAction::auto_commit` and `with_auto_commit`, drop the column from all SQL statements, and add migration 0016 to drop the `repo_actions.auto_commit` column. - Execution: stop propagating the flag into `ActionMetadata` on the local and remote paths. - builderbot-actions crate: remove the auto-commit machinery — the `AutoCommitContext` enum, `git` module, `ExecutionEvent::AutoCommit`, the post-success commit block, and the `autoCommit` field from the detector prompt and `SuggestedAction`. Verified with cargo check/clippy, the crate and store migration tests, and svelte-check/tsc. Signed-off-by: Matt Toohey <contact@matttoohey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the auto-commit option from actions across the stack. Actions no longer carry an auto-commit setting, and the supporting git-commit machinery is dropped.
Changes
builderbot-actionscrate: drop the auto-commit field from action models, remove the git-commit logic from the executor and the dedicatedgit.rsmodule, and update the detector accordingly.stagedTauri backend: remove auto-commit from action commands, events, store models, and store actions; add migration0016-drop-action-auto-committo drop the column.ActionsSettingsPanel.Net: +39 / −303 across 17 files.