Skip to content

fix: intercept parseAsync() - commander adapter#121

Merged
AmirSa12 merged 2 commits into
mainfrom
fix/parseaync
Jun 2, 2026
Merged

fix: intercept parseAsync() - commander adapter#121
AmirSa12 merged 2 commits into
mainfrom
fix/parseaync

Conversation

@AmirSa12
Copy link
Copy Markdown
Member

@AmirSa12 AmirSa12 commented Jun 2, 2026

closes #120

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 2, 2026

🦋 Changeset detected

Latest commit: b70f037

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bomb.sh/tab Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jun 2, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@bomb.sh/tab@121

commit: b70f037

@AmirSa12
Copy link
Copy Markdown
Member Author

AmirSa12 commented Jun 2, 2026

@shadowspawn you are the master of commander 😄 would really appreciate your review on this one.

P.S. I took a deep dive into the adapter while working on this, and I definitely see the rough edges you pointed out. Looking forward to collaborating on it and getting it into great shape!

@shadowspawn
Copy link
Copy Markdown

This adds parseAsync() in the same style as parse(), so a win there. 👍 (Quick look so far. Might not have time to try running it for a few days.)

(I have some experimental work on a branch to avoid needing to override parse and parseAsync by examining .rawArgs on the root instance. I wasn't happy with how some of the other things turned out on this branch, and then then got sidetracked working on the tests.)

@AmirSa12 AmirSa12 merged commit e784d62 into main Jun 2, 2026
9 checks passed
@AmirSa12 AmirSa12 deleted the fix/parseaync branch June 2, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commander adapter doesn't intercept complete -- when using parseAsync()

2 participants