Add Containerd 2.2 to k8s 1.35 variants#4801
Draft
ytsssun wants to merge 2 commits intobottlerocket-os:developfrom
Draft
Add Containerd 2.2 to k8s 1.35 variants#4801ytsssun wants to merge 2 commits intobottlerocket-os:developfrom
ytsssun wants to merge 2 commits intobottlerocket-os:developfrom
Conversation
Contributor
|
You can cherry-pick this commit - ec6cc83 and move your migration to v1.60.0 |
2ce6f0b to
87c758c
Compare
Contributor
Author
Yeah we need to consolidate on the merge. That is OK. I can resolve merge conflict after you merge the PR. Or the other way around depending on which PR gets merged earlier. |
53a6a9d to
d72021c
Compare
Signed-off-by: Yutong Sun <yutongsu@amazon.com>
d72021c to
18b26fd
Compare
Signed-off-by: Yutong Sun <yutongsu@amazon.com>
18b26fd to
32eb1e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Pending core-kit release before we can mark this PR as ready
Issue number:
Related bottlerocket-os/bottlerocket-core-kit#806
Description of changes:
Introduce containerd 2.2 for all variants currently on
containerd 2.1(27 total). Also adds thecontainer-runtime.max-concurrent-unpackssettings migration and wires up the unsupported-setting warning service so that variants on older containerd versions (1.7) log a journal warning when the setting is configured.Variants bumped to containerd 2.2:
AWS K8s:
aws-k8s-1.30-nvidia-fipsaws-k8s-1.31-nvidia-fipsaws-k8s-1.32-nvidia-fipsaws-k8s-1.33,aws-k8s-1.33-fips,aws-k8s-1.33-nvidia,aws-k8s-1.33-nvidia-fipsaws-k8s-1.34,aws-k8s-1.34-fips,aws-k8s-1.34-nvidia,aws-k8s-1.34-nvidia-fipsaws-k8s-1.35,aws-k8s-1.35-fips,aws-k8s-1.35-nvidia,aws-k8s-1.35-nvidia-fipsAWS ECS:
aws-ecs-3,aws-ecs-3-fips,aws-ecs-3-nvidia,aws-ecs-3-nvidia-fipsVMware K8s:
vmware-k8s-1.33,vmware-k8s-1.33-fipsvmware-k8s-1.34,vmware-k8s-1.34-fipsvmware-k8s-1.35,vmware-k8s-1.35-fipsDev:
aws-dev,vmware-devThe setting is opt-in only — no default value is applied. Users who want to tune concurrent unpacks can explicitly set it via
apiclient set container-runtime.max-concurrent-unpacks=<value>.Depends on:
max_concurrent_unpacksfield inContainerRuntimeSettingsV1Testing done:
Conformance tested containerd 2.2 across 20 variant/arch combinations — all passing.
max_concurrent_unpacks = 5✅UNSUPPORTED_SETTING=...written ✅Migration Testing (v1.59.0 → v1.60.0)
Built a custom TUF repo and tested upgrade/downgrade on
aws-k8s-1.35(x86_64) on an EKS 1.35 cluster.Before upgrade (v1.59.0): containerd 2.1, setting does not exist in the model.
After upgrade (v1.60.0): containerd 2.2, setting is available and functional.
Containerd config reflects the setting:
After downgrade (signpost rollback-to-inactive): Setting is cleanly removed.
Unsupported Setting Warning (aws-k8s-1.30, containerd 1.7)
Built
aws-k8s-1.30(x86_64) with the local core-kit to verify the warning infrastructure on variants that remain on older containerd versions.Setting is accepted but has no effect on containerd config:
Env file rendered at
/etc/unsupported-settings/max-concurrent-unpacks:Timer starts automatically and fires on boot:
Journal warning:
Timer fires on boot + every 6h (same cadence as existing deprecation-warning infrastructure).
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.