fix: uses Int instead of String for cpu runtime values - #1811
Open
claymcleod wants to merge 1 commit into
Open
Conversation
claymcleod
marked this pull request as ready for review
April 11, 2026 06:33
Member
|
@claymcleod Thanks so much for this contribution and highlighting the syntax issue here. Unfortunately, we do not yet have tests for any of the AoU pipelines and cannot change them at this time. We will keep this open to revisit in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on getting
sprocket lint --hide-warnings --hide-notespassing across the repository and fixing issues incrementally as I find them. This PR addresses one of those: several tasks declared theircpuruntime values asStringwhen they should beInt(orFloat).While the WDL 1.0 spec left runtime keys loosely defined, the 1.1 spec formalized
cpuwith explicit type requirements:(from the WDL 1.1 specification)
This doesn't affect execution on Cromwell, but it isn't correct per the WDL specification and
sprocket lintflags it accordingly. I figure it's worth going ahead and updating.