Skip to content

fix: uses Int instead of String for cpu runtime values - #1811

Open
claymcleod wants to merge 1 commit into
broadinstitute:developfrom
claymcleod:fix/cpu-runtime-type-mismatch
Open

fix: uses Int instead of String for cpu runtime values#1811
claymcleod wants to merge 1 commit into
broadinstitute:developfrom
claymcleod:fix/cpu-runtime-type-mismatch

Conversation

@claymcleod

@claymcleod claymcleod commented Apr 11, 2026

Copy link
Copy Markdown

I've been working on getting sprocket lint --hide-warnings --hide-notes passing across the repository and fixing issues incrementally as I find them. This PR addresses one of those: several tasks declared their cpu runtime values as String when they should be Int (or Float).

While the WDL 1.0 spec left runtime keys loosely defined, the 1.1 spec formalized cpu with explicit type requirements:

cpu

  • Accepted types:
    • Int
    • Float
  • Default value: 1

(from the WDL 1.1 specification)

This doesn't affect execution on Cromwell, but it isn't correct per the WDL specification and sprocket lint flags it accordingly. I figure it's worth going ahead and updating.

@jessicaway

Copy link
Copy Markdown
Member

@claymcleod Thanks so much for this contribution and highlighting the syntax issue here. Unfortunately, we do not yet have tests for any of the AoU pipelines and cannot change them at this time. We will keep this open to revisit in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants