domain-skills/united: full checkout flow #152
Open
bilaldaqqah wants to merge 2 commits into
Open
Conversation
…me-based selectors
✅ Skill review passedReviewed 1 file(s) — no findings. |
Contributor
There was a problem hiding this comment.
2 issues found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="domain-skills/united/checkout.md">
<violation number="1" location="domain-skills/united/checkout.md:48">
P2: Ungrouped regex alternation broadens fare-button matching and can select unintended elements.</violation>
<violation number="2" location="domain-skills/united/checkout.md:128">
P2: The documented Python wait example uses `time.sleep(3-5)`, which evaluates to a negative duration and will raise at runtime if copied.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="domain-skills/united/checkout.md">
<violation number="1" location="domain-skills/united/checkout.md:48">
P2: Stable selector regex uses `.*`, which is not newline-safe and can fail to match multiline fare-card `innerText`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| - `#DepartDate_start` (input with value like `Apr 29`) | ||
|
|
||
| Results / fare drawer: | ||
| - Price card buttons: `button` whose innerText matches `/From\s*\$\d+.*(Economy|First)/` (no stable id — the id attribute is empty). |
Contributor
There was a problem hiding this comment.
P2: Stable selector regex uses .*, which is not newline-safe and can fail to match multiline fare-card innerText.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At domain-skills/united/checkout.md, line 48:
<comment>Stable selector regex uses `.*`, which is not newline-safe and can fail to match multiline fare-card `innerText`.</comment>
<file context>
@@ -45,7 +45,7 @@ Home search widget:
Results / fare drawer:
-- Price card buttons: `button` whose innerText matches `/From\s*\$\d+.*Economy|First/` (no stable id — the id attribute is empty).
+- Price card buttons: `button` whose innerText matches `/From\s*\$\d+.*(Economy|First)/` (no stable id — the id attribute is empty).
- Basic Economy ack checkbox: `input[type=checkbox]` inside `.app-pod-shopping-nestedFSR-NestedPriceCards-styles__basicFooter--*` (UUID id).
- Fare Select buttons: `button[aria-label^="Select United Economy Basic"]`, `"Select United Economy Standard"`, `"Select United Economy Flexible"`. Each has `aria-describedby="nested-atc-btn-ECO-BASIC|ECO-STANDARD|ECO-FLEX"` — stable across rows.
</file context>
Suggested change
| - Price card buttons: `button` whose innerText matches `/From\s*\$\d+.*(Economy|First)/` (no stable id — the id attribute is empty). | |
| - Price card buttons: `button` whose innerText matches `/From\s*\$\d+[\s\S]*(Economy|First)/` (no stable id — the id attribute is empty). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End-to-end booking on united.com: search → fare → traveler → seatmap → checkout, all in one session.
Highlights
_abckcookie stays~0~(unflagged) through every step. Nosensor_datachallenge, no 403/429, no PerimeterX. This contradicts what stock Playwright typically sees on this site.
click(x, y)on the homepage Find-flights submit and fare-drawer Select buttons is pixel-correct but React's synthetic-event handler never fires. Switchto
element.click()viajs()— works everywhere.Selectbutton is silentlydisabled=""until an unlabeled ack checkbox inside.basicFooter--*is clicked.input[name="rtiTraveler.travelers[0].firstName|...]"andinput[name="commonpayment.cardInfo.cardNumber|expiryDate|..."]are stable.<input type=tel>elements.#stateFilteris an autocomplete text input, not a select.Summary by cubic
Adds a united.com flight checkout skill doc focused on reliable automation from real Chrome (CDP). Covers the full flow with stable selectors, JS click guidance, and Akamai notes (no
_abckflagging), plus small fixes to selectors and waits.New Features
cartId.element.click(); use coordinate clicks only to focus text inputs.#stateFilterautocomplete._abck,bm_*) present but not flagged; no login required to reach card entry.Bug Fixes
Written for commit 931ed87. Summary will update on new commits.