chore(ui/dashboard): replace watch() with getValues/useWatch in form handlers - #2586
Draft
steveninhle wants to merge 1 commit into
Draft
chore(ui/dashboard): replace watch() with getValues/useWatch in form handlers#2586steveninhle wants to merge 1 commit into
steveninhle wants to merge 1 commit into
Conversation
steveninhle
force-pushed
the
chore/fix-watch-subscriptions
branch
from
June 26, 2026 01:52
282ef4e to
b1234e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
watch()calls inside event handlers withgetValues()inVariationsSwitch— eliminates 6 reactive subscriptions that only needed a point-in-time readwatch('environmentId')calls into a single subscription inPushCreateUpdateModalwatch('featureId')withuseWatchinExperimentCreateUpdateModalandExperimentSettingsto scope re-renders to only those componentswatch('variations')withuseWatchinDefaultVariationsfor the same reasonWhy
watch('field')called at the top level of a component (or inside a handler) registers a reactive subscription: every time that field changes, the entire component re-renders. In handlers, only the current value is needed — no subscription required.getValues()reads the value without subscribing. For render-time values that belong to a child/leaf component,useWatchconfines the re-render to that component instead of bubbling it up to the parent.